From owner-svn-src-projects@FreeBSD.ORG Fri Nov 7 23:50:05 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C4990FFC; Fri, 7 Nov 2014 23:50:05 +0000 (UTC) Received: from mail107.syd.optusnet.com.au (mail107.syd.optusnet.com.au [211.29.132.53]) by mx1.freebsd.org (Postfix) with ESMTP id 88FE6DDD; Fri, 7 Nov 2014 23:50:05 +0000 (UTC) Received: from c122-106-147-133.carlnfd1.nsw.optusnet.com.au (c122-106-147-133.carlnfd1.nsw.optusnet.com.au [122.106.147.133]) by mail107.syd.optusnet.com.au (Postfix) with ESMTPS id 32DAFD46C92; Sat, 8 Nov 2014 10:49:58 +1100 (AEDT) Date: Sat, 8 Nov 2014 10:49:54 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: "Alexander V. Chernikov" Subject: Re: svn commit: r274256 - in projects/routing/sys: net netinet netinet6 netpfil/pf In-Reply-To: <201411072252.sA7Mq3u6006585@svn.freebsd.org> Message-ID: <20141108104426.X2034@besplex.bde.org> References: <201411072252.sA7Mq3u6006585@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=dMCfxopb c=1 sm=1 tr=0 a=7NqvjVvQucbO2RlWB8PEog==:117 a=PO7r1zJSAAAA:8 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=h8u5PeLbQoWTW2kpvDcA:9 a=CjuIK1q_8ugA:10 Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 23:50:05 -0000 On Fri, 7 Nov 2014, Alexander V. Chernikov wrote: > Log: > Split radix implementation and system route table structure: > use new 'struct radix_head' for radix. > Modified: projects/routing/sys/net/radix.c > ============================================================================== > --- projects/routing/sys/net/radix.c Fri Nov 7 22:02:44 2014 (r274255) > +++ projects/routing/sys/net/radix.c Fri Nov 7 22:52:02 2014 (r274256) > ... > @@ -1132,13 +1134,13 @@ rn_inithead_internal(void **head, int of > tt->rn_bit = -1 - off; > *ttt = *tt; > ttt->rn_key = rn_ones; > - rnh->rnh_addaddr = rn_addroute; > - rnh->rnh_deladdr = rn_delete; > - rnh->rnh_matchaddr = rn_match; > - rnh->rnh_lookup = rn_lookup; > - rnh->rnh_walktree = rn_walktree; > - rnh->rnh_walktree_from = rn_walktree_from; > - rnh->rnh_treetop = t; > + rnh->rnh_addaddr = (rn_addaddr_f_t *)rn_addroute; > + rnh->rnh_deladdr = (rn_deladdr_f_t *)rn_delete; > + rnh->rnh_matchaddr = (rn_matchaddr_f_t *)rn_match; > + rnh->rnh_lookup = (rn_lookup_f_t *)rn_lookup; > + rnh->rnh_walktree = (rn_walktree_t *)rn_walktree; > + rnh->rnh_walktree_from = (rn_walktree_from_t *)rn_walktree_from; > + rnh->rh.rnh_treetop = t; > return (1); > } > A previous commit added lots of function typedefs. As I feared, most uses of these are to give undefined behaviour by bogusly casting using the typedefs. Unless the function types are actually the same. Then the bogus casts have no effect. These typedefs don't seem to be used to obfuscate function definitions yet. Bruce