Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Jan 2012 11:05:22 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Kevin Lo <kevlo@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r230208 - head/sys/fs/tmpfs
Message-ID:  <201201171105.23029.jhb@freebsd.org>
In-Reply-To: <201201170950.15267.jhb@freebsd.org>
References:  <201201161025.q0GAPNDq027693@svn.freebsd.org> <201201170950.15267.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, January 17, 2012 9:50:15 am John Baldwin wrote:
> On Monday, January 16, 2012 5:25:23 am Kevin Lo wrote:
> > Author: kevlo
> > Date: Mon Jan 16 10:25:22 2012
> > New Revision: 230208
> > URL: http://svn.freebsd.org/changeset/base/230208
> > 
> > Log:
> >   Add nfs export support to tmpfs(5)
> >   
> >   Reviewed by:	kib
> > 
> > Modified:
> >   head/sys/fs/tmpfs/tmpfs_vfsops.c
> > 
> > Modified: head/sys/fs/tmpfs/tmpfs_vfsops.c
> > 
> ==============================================================================
> > --- head/sys/fs/tmpfs/tmpfs_vfsops.c	Mon Jan 16 09:53:24 2012	(r230207)
> > +++ head/sys/fs/tmpfs/tmpfs_vfsops.c	Mon Jan 16 10:25:22 2012	(r230208)
> > @@ -150,10 +150,8 @@ tmpfs_mount(struct mount *mp)
> >  		return (EINVAL);
> >  
> >  	if (mp->mnt_flag & MNT_UPDATE) {
> > -		/* XXX: There is no support yet to update file system
> > -		 * settings.  Should be added. */
> > -
> > -		return EOPNOTSUPP;
> > +		if (vfs_flagopt(mp->mnt_optnew, "export", NULL, 0))
> > +			return (0);
> >  	}
> 
> Is it supposed to fall through if the 'export' option isn't in the list during 
> an update mount?

Nevermind, was supposed to have deleted this from my pending send queue before
it went out.  This was fixed in a subsequent commit.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201171105.23029.jhb>