From owner-freebsd-current@FreeBSD.ORG  Mon Sep 20 20:12:01 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BD6DE16A4DE
	for <freebsd-current@FreeBSD.org>;
	Mon, 20 Sep 2004 20:12:01 +0000 (GMT)
Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8EE2D43D5D
	for <freebsd-current@FreeBSD.org>;
	Mon, 20 Sep 2004 20:12:01 +0000 (GMT)	(envelope-from jhb@FreeBSD.org)
Received: (qmail 2009 invoked from network); 20 Sep 2004 20:12:01 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <rosti_bsd@yahoo.com>; 20 Sep 2004 20:12:00 -0000
Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i8KKBt4f025478;
	Mon, 20 Sep 2004 16:11:57 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: freebsd-current@FreeBSD.org
Date: Mon, 20 Sep 2004 15:25:38 -0400
User-Agent: KMail/1.6.2
References: <20040918151924.98910.qmail@web14828.mail.yahoo.com>
In-Reply-To: <20040918151924.98910.qmail@web14828.mail.yahoo.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200409201525.38754.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
cc: Rostislav Krasny <rosti_bsd@yahoo.com>
Subject: Re: patch: selecting "All" on some of sysinstall(8) menus doesn't
	make any distribution marked
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Sep 2004 20:12:01 -0000

On Saturday 18 September 2004 11:19 am, Rostislav Krasny wrote:
> > uname -a
>
> FreeBSD localhost 5.3-BETA4 FreeBSD 5.3-BETA4 #0: Thu Sep 16 19:19:27
> IDT 2004     root@localhost:/usr/obj/usr/src/sys/GENERIC  i386
>
> Hi,
>
> When one select "All" on some of the "Distributions" menus of
> sysinstall(8) no distribution is marked but actually all of them are
> selected for installation. It can confuse one during a new system
> installation. Following patch fixes this problem:
>
> --- dist.c.prev Sat Sep 18 17:37:01 2004
> +++ dist.c      Sat Sep 18 17:38:06 2004
> @@ -291,7 +291,7 @@
>      XOrgDists = DIST_XORG_ALL;
>      i = distMaybeSetPorts(self);
>      distVerifyFlags();
> -    return i;
> +    return i | DITEM_REDRAW;
>  }
>
>  static int
>
>
> If you want test this patch on installed system try following scenario
> before and after applying it to your source:
>
> 1. run 'sysinstall' as a root
> 2. go to "Custom | Distributions" or to "Custom | Distributions |
> Custom" menu
> 3. select "All" on the menu and see what distributions are marked after
> that
>
> P.S. If this patch is correct it should be commited to 5.3 before the
> release, IMHO.

Committed to HEAD.  I'll put it in 5.3 if re@ oks it.  Thanks!

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org