From nobody Sun Apr 24 21:12:22 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B14D51A8A1CC; Sun, 24 Apr 2022 21:12:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kmgny4cCVz53n0; Sun, 24 Apr 2022 21:12:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650834742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BEdPu537HWAbZn4MDjx4n9gRshlGlZrwF69PpzvwQtE=; b=bXp/wLnK8R6wgWgG16dYcZqEOtYDkBrzmiLEJYJzBTzNAZ6lTk4Vs/AXbkLUhi9HKLEJoD ZKC8zSGJ7j/z8v+qc78iOtElunrp2gnpyiorzsCCS9YNIvOXF0O6jKstC6iOfY/omyG7d2 4V+GX+b+ataXms17rHh4Pr4DFlrWjUQ22uGHrWQqrO9gY0laRsqnhoEmmULaENCF1h+sE8 3r+knvJ17+ldYawOwt0HJoJ4VLZW2uaLP/hWZ1NLgax3Dn7HlrgwibDLBGCn/nQxFJzHmw j2oz3kFp1d3cabBUJ2156sm+Wc1hn1maw1xrOqBQVD8og77YWtfzEBjWCHoLtg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7F7185F3C; Sun, 24 Apr 2022 21:12:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23OLCMEM043888; Sun, 24 Apr 2022 21:12:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23OLCMnD043887; Sun, 24 Apr 2022 21:12:22 GMT (envelope-from git) Date: Sun, 24 Apr 2022 21:12:22 GMT Message-Id: <202204242112.23OLCMnD043887@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 48ae3f4f64ca - main - ata/nvme: Add comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 48ae3f4f64ca3c414658533e7ac8172973627c53 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650834742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BEdPu537HWAbZn4MDjx4n9gRshlGlZrwF69PpzvwQtE=; b=Le07bMznGzje6zsuCfKJO2GEnWQGK+GWxU6WFBxqN2eFKIrdM2/QhkmDLzdThlIKqI4QsS c/5NtS5PVAKveezRYZ1QefoR78FkGPTQA5MByLSPPDT/8rB7WIldvEn6RHGyBCJLRiBLMR /+5pe4ZrQ9PlD7t05t4r9+crnXJZdN/758SP7xXtxGtci2wwqQKJJKntUtpemlrIrrZfMN SAHJV4gaYSDNnT85yFQGxa3BTo2gGcGNeyVd1chHbKFBzD4MgwhfQbW/Pc9kFMvpofHUGY zcXk2IySUlggvitXsyPCf8M1fSoAXt4Eu0ml9MMlSClZo42hper13V0DnLNvHA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650834742; a=rsa-sha256; cv=none; b=uAFi0YHLqYiuabm1NnplF42nXnWuZFnLg08w3TDvqKJkf0ce6DqxOKRBZiVZ8F3FgTQXf/ y0B7Hpk7Ng7z6IjHaAxYB/thk/0FVTSsrsMMOFIryZALn2az7uHuzKyGO9M4iGKMkKdjXm sL9ojaVAXL3kcUS8z3Fw8xlIH4R0nVa6Q8AAk7uHkn1ATLjFh4i6iVu8mrJ1BmBY/IdLoh Mn0YQBUOKQ4vRQiltiXx3PgBvUPUAyKFVMh+nCAPMZWvTlnqZ7nJEGhA1hR4j1Npl9bhan yn9GTHiBZf8I+hUuMMZg9Ux2gJJXOtJQ5MpCSjb2IMmLKT5zwGCtxSbT1XGqsw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=48ae3f4f64ca3c414658533e7ac8172973627c53 commit 48ae3f4f64ca3c414658533e7ac8172973627c53 Author: Warner Losh AuthorDate: 2022-04-24 21:11:52 +0000 Commit: Warner Losh CommitDate: 2022-04-24 21:11:52 +0000 ata/nvme: Add comment Steal the comment from daonninvalidate about the call to disk_gone(). Sponsored by: Netflix --- sys/cam/ata/ata_da.c | 4 ++++ sys/cam/nvme/nvme_da.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c index 9a57c3f3affa..2623d8919e06 100644 --- a/sys/cam/ata/ata_da.c +++ b/sys/cam/ata/ata_da.c @@ -1246,6 +1246,10 @@ adaoninvalidate(struct cam_periph *periph) */ cam_iosched_flush(softc->cam_iosched, NULL, ENXIO); + /* + * Tell GEOM that we've gone away, we'll get a callback when it is + * done cleaning up its resources. + */ disk_gone(softc->disk); } diff --git a/sys/cam/nvme/nvme_da.c b/sys/cam/nvme/nvme_da.c index f47a7f9e2271..c7cedec894ac 100644 --- a/sys/cam/nvme/nvme_da.c +++ b/sys/cam/nvme/nvme_da.c @@ -608,6 +608,10 @@ ndaoninvalidate(struct cam_periph *periph) */ cam_iosched_flush(softc->cam_iosched, NULL, ENXIO); + /* + * Tell GEOM that we've gone away, we'll get a callback when it is + * done cleaning up its resources. + */ disk_gone(softc->disk); }