Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Apr 2022 21:12:22 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 48ae3f4f64ca - main - ata/nvme: Add comment
Message-ID:  <202204242112.23OLCMnD043887@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=48ae3f4f64ca3c414658533e7ac8172973627c53

commit 48ae3f4f64ca3c414658533e7ac8172973627c53
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-04-24 21:11:52 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-04-24 21:11:52 +0000

    ata/nvme: Add comment
    
    Steal the comment from daonninvalidate about the call to disk_gone().
    
    Sponsored by:           Netflix
---
 sys/cam/ata/ata_da.c   | 4 ++++
 sys/cam/nvme/nvme_da.c | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c
index 9a57c3f3affa..2623d8919e06 100644
--- a/sys/cam/ata/ata_da.c
+++ b/sys/cam/ata/ata_da.c
@@ -1246,6 +1246,10 @@ adaoninvalidate(struct cam_periph *periph)
 	 */
 	cam_iosched_flush(softc->cam_iosched, NULL, ENXIO);
 
+	/*
+	 * Tell GEOM that we've gone away, we'll get a callback when it is
+	 * done cleaning up its resources.
+	 */
 	disk_gone(softc->disk);
 }
 
diff --git a/sys/cam/nvme/nvme_da.c b/sys/cam/nvme/nvme_da.c
index f47a7f9e2271..c7cedec894ac 100644
--- a/sys/cam/nvme/nvme_da.c
+++ b/sys/cam/nvme/nvme_da.c
@@ -608,6 +608,10 @@ ndaoninvalidate(struct cam_periph *periph)
 	 */
 	cam_iosched_flush(softc->cam_iosched, NULL, ENXIO);
 
+	/*
+	 * Tell GEOM that we've gone away, we'll get a callback when it is
+	 * done cleaning up its resources.
+	 */
 	disk_gone(softc->disk);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202204242112.23OLCMnD043887>