From owner-p4-projects  Thu May  9 16: 7:48 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0BAE937B403; Thu,  9 May 2002 16:07:43 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4558837B409
	for <perforce@freebsd.org>; Thu,  9 May 2002 16:07:42 -0700 (PDT)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g49N7gm68486
	for perforce@freebsd.org; Thu, 9 May 2002 16:07:42 -0700 (PDT)
	(envelope-from amigus@tislabs.com)
Date: Thu, 9 May 2002 16:07:42 -0700 (PDT)
Message-Id: <200205092307.g49N7gm68486@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to amigus@tislabs.com using -f
From: Adam Migus <amigus@FreeBSD.org>
Subject: PERFORCE change 11069 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=11069

Change 11069 by amigus@amigus_ganymede on 2002/05/09 16:07:03

	Forgot to fdrop() if fget() succeeded.  Doh!

Affected files ...

... //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#139 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#139 (text+ko) ====

@@ -1721,7 +1721,7 @@
 
 	error = fget(td, SCARG(uap, fd), &fp);
 	if (error)
-		goto out;
+		goto out2;
 
 	if(fp->f_type != DTYPE_SOCKET) {
 		error = EINVAL;
@@ -1734,9 +1734,9 @@
 
 	if (error == 0)
 		error = copyout(&label, SCARG(uap, mac_p), sizeof(label));
+out:
  	fdrop(fp, td);
-
-out:
+out2:
 	mtx_unlock(&Giant);
 	return (error);
 }

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message