From owner-cvs-src@FreeBSD.ORG Thu Dec 2 10:52:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE0B016A4CF for ; Thu, 2 Dec 2004 10:52:23 +0000 (GMT) Received: from tx2.mail.ox.ac.uk (tx2.mail.ox.ac.uk [163.1.2.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE24B43D4C for ; Thu, 2 Dec 2004 10:52:22 +0000 (GMT) (envelope-from colin.percival@wadham.ox.ac.uk) Received: from scan2.mail.ox.ac.uk ([163.1.2.162] helo=localhost) by tx2.mail.ox.ac.uk with esmtp (Exim 4.42) id 1CZoZS-00078A-7e for cvs-src@freebsd.org; Thu, 02 Dec 2004 10:52:22 +0000 Received: from rx2.mail.ox.ac.uk ([163.1.2.161]) by localhost (scan2.mail.ox.ac.uk [163.1.2.162]) (amavisd-new, port 25) with ESMTP id 26881-07 for ; Thu, 2 Dec 2004 10:52:22 +0000 (GMT) Received: from smtp0.herald.ox.ac.uk ([163.1.0.246]) by rx2.mail.ox.ac.uk with esmtp (Exim 4.42) id 1CZoZR-00077r-8i; Thu, 02 Dec 2004 10:52:21 +0000 Received: from dhcp1203.wadham.ox.ac.uk ([163.1.161.203]) by smtp0.herald.ox.ac.uk with esmtp (Exim 3.35 #1) id 1CZoZR-0001PB-3y; Thu, 02 Dec 2004 10:52:21 +0000 Message-ID: <41AEF3E4.7070408@wadham.ox.ac.uk> Date: Thu, 02 Dec 2004 10:52:20 +0000 From: Colin Percival User-Agent: Mozilla Thunderbird 0.9 (X11/20041107) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200412012133.iB1LX2JC019417@repoman.freebsd.org> <20041201225141.GA813@darkness.comp.waw.pl> In-Reply-To: <20041201225141.GA813@darkness.comp.waw.pl> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Colin Percival Subject: Re: cvs commit: src/sys/compat/linprocfs linprocfs.csrc/sys/fs/procfs procfs_status.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2004 10:52:24 -0000 Pawel Jakub Dawidek wrote: > On Wed, Dec 01, 2004 at 09:33:02PM +0000, Colin Percival wrote: > +> Fix unvalidated pointer dereference. This is FreeBSD-SA-04:17.procfs. > > BTW. Why we don't check sbuf_copyin() return value here? For the security advisory, I wanted to fix the security problem without changing the existing behaviour. Right now, if argv is ("hello", NULL, "world"), then /proc/curproc/cmdline will give you "hello\0\0world\0". I have no objection to this behaviour being changed on -current, but we can't change how the security (or arguably, the stable) branches behave now. Colin Percival