From nobody Fri Jan 7 10:30:31 2022 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A89B2193754B for ; Fri, 7 Jan 2022 10:30:44 +0000 (UTC) (envelope-from marco@crowdsec.net) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JVfcz66B8z3N6w for ; Fri, 7 Jan 2022 10:30:43 +0000 (UTC) (envelope-from marco@crowdsec.net) Received: by mail-lf1-x12c.google.com with SMTP id o12so14017708lfk.1 for ; Fri, 07 Jan 2022 02:30:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crowdsec-net.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=0j85b9s1z1XjszQ+aMDsNJA6T5TTQLsFNoG5tHuL+NQ=; b=TMAqwM3T4YvIWsTx6+zBcn8Chj2bNoKgWZWjlijqo6XMFUpioV3gFUX2GYMyyVUdSI zLPE1TZov8gXLwJ1aXbE1SKzxMfwK/+kw0eY0YWGUMvNfbSR6r9Ki09E9ukgZvIyKu23 t17clHi4tdLgyg4vSSGOQ5hP8LMMH2e5qhA7B2J52N6NmqnKGYLJwESSClsr1uAX9JOd Qtu+K6EC+hrzI8RuGsa/PkStg7fu0qM7TQHXDkddf9cO8XM0Mm58OODbIv5t/exVklkz u8wiVxyl9p3Ffgpg0Qtu+6udFsJfzFEu1HzvYABtMTYem6H5ww2i+t5gOBldnAZ0NH4b Rnxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=0j85b9s1z1XjszQ+aMDsNJA6T5TTQLsFNoG5tHuL+NQ=; b=cggkzhA0MA2uwnHwrGQmT5FwEkTdQB/i9/s2n216YPu72weZXQXsz0a17DmyDfhtWj bGsFHCGPgdQq3d9+4O9MjwJ/qe88U6/wSnCSginpYdjmnR5FrjDhEiYrBsvbVMXdaACc nZ3S9uJf7stFKfASz0+u5yd1/AWgkqZaTG2+iw3G/hVaB+rJdMFQdP9r/VorbuQir6cU IF0vK1rGIGO/wnqLw2x/2u+PyRrM/y7KeMK0oQJLlJ9JZX1diSpimFoo2jTtJ3jNuNn4 tKzbyoRq3vkfDOoCSVawiBDGxOHgM22QnEL4PTbHQQ4f3f/HA0gLayMryJTBHvPzL3is L3/A== X-Gm-Message-State: AOAM530GwRJqKh/m0e1g8ZZSaGWVMeyzerpOZ36a95MoB53A+k4KQMpv vNpukofdIRJJTU86/bjxRcMMQoDngx07WUk39MK5FMmEhVOeRKRG X-Google-Smtp-Source: ABdhPJwPoEocifHXFbIUflp0qUs3bgSq5B55I8bActYxC/T2juGQslXbGEBlrxpa2g8QcRBQtOWNZsZsaYOWKb7w9Lw= X-Received: by 2002:a05:6512:40f:: with SMTP id u15mr10481503lfk.3.1641551442312; Fri, 07 Jan 2022 02:30:42 -0800 (PST) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: marco+freebsd@crowdsec.net Date: Fri, 7 Jan 2022 11:30:31 +0100 Message-ID: Subject: Re: Go dependencies and broken build To: freebsd-ports@freebsd.org Content-Type: multipart/alternative; boundary="00000000000099a23205d4fb7a69" X-Rspamd-Queue-Id: 4JVfcz66B8z3N6w X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=crowdsec-net.20210112.gappssmtp.com header.s=20210112 header.b=TMAqwM3T; dmarc=none; spf=pass (mx1.freebsd.org: domain of marco@crowdsec.net designates 2a00:1450:4864:20::12c as permitted sender) smtp.mailfrom=marco@crowdsec.net X-Spamd-Result: default: False [-1.51 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[crowdsec-net.20210112.gappssmtp.com:s=20210112]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; NEURAL_SPAM_MEDIUM(0.84)[0.839]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.85)[-0.846]; DMARC_NA(0.00)[crowdsec.net]; DKIM_TRACE(0.00)[crowdsec-net.20210112.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.998]; FROM_NO_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::12c:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; TAGGED_FROM(0.00)[freebsd]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-ThisMailContainsUnwantedMimeParts: N --00000000000099a23205d4fb7a69 Content-Type: text/plain; charset="UTF-8" Hello! I follow up on my own email to correct the link: the bug is actually https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260262 It has now been re-assigned to nobody. Can someone take it and commit the new patches? That would allow us to have a new official version and publish the related OPNSense plugin. Thanks again, Marco On Mon, Jan 3, 2022 at 2:05 PM Marco Mariani wrote: > Hello! > > I am in charge of maintaining the ports of security/crowdsec and > security/crowdsec-firewall-bouncer, which are currently broken since a > couple of weeks for not providing all Go dependencies before build time. > I work for the upstream company but had little previous freebsd > experience, hence the bug on my first port submission. > > Now, for the short term, I have submitted a fix that builds from a git tag > with all vendored dependencies, and added the patch to > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260264 > > I understand the previous maintainer (to whom the bug is assigned) has > little time right now to review and commit again, so if somebody could > have a look it would be greatly appreciated. > > In the long term, I'd like to avoid vendoring everything, which is not > recommended by core Go devs anymore. > The version of the port I inherited made use of go:modules from Mk/Uses/ > go.mk, but our software has since grown some plugins as sub-projects with > their own dependencies. It was a lot simpler to just call our own Makefile, > as I did in > https://github.com/crowdsecurity/packaging-freebsd/blob/master/security/crowdsec/Makefile > > My approach should then be to port the technique from go.mk to our > Makefile (and run "go mod download", "go mod vendor".. by hand). > > A bit tricky (it would create one set of .zip and .mod for each plugin) > but it should be doable. What do you think? Is there a simpler way? > > Thanks, > Marco > --00000000000099a23205d4fb7a69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello!

I follow up on my own= email to correct the link: the bug is actually https://bugs.freebsd.org/bugzil= la/show_bug.cgi?id=3D260262

It has now been re= -assigned to nobody.
Can someone take it and commit the new = patches?
That would allow us to have a new official version and p= ublish the related OPNSense plugin.

Thanks aga= in,
Marco



<= /div>
O= n Mon, Jan 3, 2022 at 2:05 PM Marco Mariani <marco@crowdsec.net> wrote:
Hello!

I am in ch= arge of maintaining the ports of security/crowdsec and security/crowdsec-fi= rewall-bouncer, which are currently broken since a couple of weeks for not = providing all Go=C2=A0 dependencies before build time.
I work for= the upstream company but had little previous freebsd experience, hence the= bug on my first port submission.

Now, for the short term, I h= ave submitted a fix that builds from a git tag with all vendored dependenci= es, and added the patch to https://bugs.freebsd.org/bugzilla/= show_bug.cgi?id=3D260264

I understand the previous maintainer (t= o whom the bug is assigned) has little time right now to review and commit = again,=C2=A0 so if somebody could have a look it would be greatly appreciat= ed.

In the long term, I'd like to avoid vendoring everythin= g, which is not recommended by core Go devs anymore.
The version = of the port I inherited made use of go:modules from Mk/Uses/go.mk, but our software has since grown som= e plugins as sub-projects with their own dependencies. It was a lot simpler= to just call our own Makefile, as I did in https://github.com/crowdsecurity/packaging-freebsd/blob/maste= r/security/crowdsec/Makefile

My approach shoul= d then be to port the technique from go.mk to our Makefile (and run "go mod download", "= go mod vendor".. by hand).

A bit tricky (it would create = one set of .zip and .mod for each plugin) but it should be doable. What do = you think? Is there a simpler way?

Thanks,
Marco
--00000000000099a23205d4fb7a69--