From owner-freebsd-current Sun Dec 27 12:17:20 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id MAA29572 for freebsd-current-outgoing; Sun, 27 Dec 1998 12:17:20 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA29566 for ; Sun, 27 Dec 1998 12:17:18 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.1/8.9.1) id MAA51694; Sun, 27 Dec 1998 12:16:55 -0800 (PST) (envelope-from dillon) Date: Sun, 27 Dec 1998 12:16:55 -0800 (PST) From: Matthew Dillon Message-Id: <199812272016.MAA51694@apollo.backplane.com> To: Brian Feldman Cc: current@FreeBSD.ORG Subject: Re: "ICMP_BANDLIM" References: Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG : Does anyone have an aversion to options "ICMP_BANDLIM" going into GENERIC? I :think it's very justifiable, and doesn't bloat the kernel unnecessarily (also, :Solaris and Linux, that I know of so far, also do this, so it's a pretty :standard thing). And how about using an option "ICMP_BANDLIM_SILENT" as well? :Sometimes you don't really want to see your message buffer filling up with :ICMP_BANDLIM messages, and option "ICMP_BANDLIM_SILENT" would probably go into :GENERIC too. If everyone thinks this is a good idea, I'll make the patches to :src/sys/netinet/ip_input.c src/sys/{i386,alpha}/conf/GENERIC :src/sys/i386/conf/options.i386 src/sys/alpha/conf/options.alpha and maybe PC98? :PC98 should probably be left alone... : :Comments? I was planning on waiting a release but it does appear to be solid, I think we can enable it permanently. The bandlim error messages are rate limited, it should not create a burden on the log files, but I suppose a silent option could be added - no skin off the code's nose :-) The only problem is that I do not have time to do it right now and my code tree is sitting on the floor in pieces while I work on the swap system. If a committer wants to commit the appropriate changes please feel free! -Matt : Brian Feldman _ __ ___ ___ ___ : green@unixhelp.org _ __ ___ | _ ) __| \ : http://www.freebsd.org/ _ __ ___ ____ | _ \__ \ |) | : FreeBSD: The Power to Serve! _ __ ___ ____ _____ |___/___/___/ : : :To Unsubscribe: send mail to majordomo@FreeBSD.org :with "unsubscribe freebsd-current" in the body of the message : Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet Communications & God knows what else. (Please include original email in any response) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message