From owner-cvs-src@FreeBSD.ORG Wed Jul 23 10:14:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B9E437B404 for ; Wed, 23 Jul 2003 10:14:59 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 23CF843F75 for ; Wed, 23 Jul 2003 10:14:58 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 39580 invoked by uid 1000); 23 Jul 2003 17:14:58 -0000 Date: Wed, 23 Jul 2003 10:14:58 -0700 (PDT) From: Nate Lawson To: Garance A Drosihn In-Reply-To: Message-ID: <20030723101220.B39567@root.org> References: <20030723003212.1606C2A8B2@canning.wemm.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 17:14:59 -0000 On Tue, 22 Jul 2003, Garance A Drosihn wrote: > At 5:32 PM -0700 7/22/03, Peter Wemm wrote: > >Take the i386 interrupt vector code. Thats an example where > >it is massively inlined. Having a non-inlined function that > >does all the calculations and bit shifting is much smaller > >in code size, but slower at runtime. > > If I understand this discussion correctly, then the previous > version of gcc (in freebsd-current) was NOT inlining these > sections event though we thought it was. Might we expect some > performance improvements now that we know to force gcc to > inline the functions? Excellent troll. :) [FYI, the long-winded discussion underway is whether the many cases of inlining actually do have any performance gain. Not all requests for inline were rejected, only those for "large" functions where gcc's idea of large is also being debated.] -Nate