From nobody Sun Feb 5 01:07:28 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P8WTD0Ls6z3kdl8 for ; Sun, 5 Feb 2023 01:07:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P8WTC5pnVz45fZ for ; Sun, 5 Feb 2023 01:07:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675559247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s95O3zckU7uhs2eODfnx80OqN42m3TIG0YpcUqfqWmo=; b=D6fd9j4gWah5NpqvxYFPGcIbljXH9p5q5A04abI/8I5eVIOpX5QZo513OWRpTbfajtV3Do TRXgzxRcJmnTYWFGrZTa/q0DAolHnO0y723hKQKGfNv5ed9yQrvT8KIPmnvEZhBMDkxGX/ TLRQAsFIWVdyB9u/MuqdbM8AiodNYDXT14FyV73EHV+De4dhGkg+j1VxEvZn2h0wQZYUbr jQEV5cviVheb8qt9CrTyts60i7BhFS4VK6r1F4jlDM8V+jmIchGIlIxY9Tu8Ysa/5IoOqy RPjaMK//KJCSDyfPBzwoqJkW51C9VokA1Q9xW9JUis24dWlsyy5YOX6mF7oeew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675559247; a=rsa-sha256; cv=none; b=TeOZc7WvuUihHMavBBEXkr0SC/K8url7GEBx21NvNUxhF+dxW3C09urMfKHK+w+0zYCqDD jrwj7/sbhIiRjm531KolwdntC9zH1Sl7TGg7aiSZy0fk6nOGnbHILf9ElM1ryDkOkho75A c5p4aGEfU27AEhUUuLhFdqV7SjgELIqLqyxx/HOAEJ7037t0eBeVhDYp4vu3CToNUlDQIN EmQIAzA9WLfC0duhImGHpAdxcr/AQXZhYKVY6yi/myEu1mPDuV+9Fg8NoLBNwLKNoKdjHZ uNRWaLuB9m3dWYPrRWP/tyq5K3rCv5TqYhwUWxCDThxFRUzA7B8ABcoJZ2m5Wg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P8WTC4srszZh0 for ; Sun, 5 Feb 2023 01:07:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31517R08094990 for ; Sun, 5 Feb 2023 01:07:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31517RvK094989 for bugs@FreeBSD.org; Sun, 5 Feb 2023 01:07:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 269328] nfs client: data corruption using fspacectl and mmap Date: Sun, 05 Feb 2023 01:07:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269328 --- Comment #1 from Rick Macklem --- I wonder if 3b6056204dd8 that was just committed by kib@ might fix this? For a 13.1 server (which does not support the Deallocate operation), the client uses vop_stddeallocate() and it uses vn_bmap_seekhole_locked(). If it doesn't fix the problem, then I'd guess nfs_deallocate() needs a fix for the generic case where it calls vop_stddeallocate(). nfs_deallocate() does call vnode_pager_purge_range() before doing the RPC, but that won't happen against a 13.1 server. It's not clear to me how vnode_pager_purge_range() compares to doing a vm_object_page_clean()? I'll try to test against a 14 server that supports Deallocate. If you can test with a client with 3b6056204dd8 and let us know if it helps, that would be nice. --=20 You are receiving this mail because: You are the assignee for the bug.=