Date: Mon, 17 Oct 2016 12:03:44 -0500 From: John Marino <freebsd.contact@marino.st> To: Mathieu Arnold <mat@FreeBSD.org>, marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files Message-ID: <8cca7750-291e-c7c9-72aa-f91d17373046@marino.st> In-Reply-To: <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org> References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <d8557129-7ede-8ba7-7b8e-8745563930a2@marino.st> <b09dc39e-1656-5f35-cf72-bb4469d350b6@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/17/2016 12:01, Mathieu Arnold wrote:
> Le 17/10/2016 à 18:31, John Marino a écrit :
>>
>>
>> On 10/17/2016 11:28, Mathieu Arnold wrote:
>>> Le 17/10/2016 à 18:26, John Marino a écrit :
>>>> On 10/17/2016 11:20, Mathieu Arnold wrote:
>>>>> Le 17/10/2016 à 17:55, John Marino a écrit :
>>>>>> On 10/17/2016 10:52, Mathieu Arnold wrote:
>>>>>>> Le 17/10/2016 à 17:15, John Marino a écrit :
>>>>>>>> Apparently USES=pathfix and USES=autoreconf can't be used
>>>>>>>> together, so
>>>>>>>> the pkgconfig directory is now passed via MAKE_ARGS
>>>>>>>
>>>>>>> That is mostly not true. What usage makes it so that they do not
>>>>>>> work
>>>>>>> together ?
>>>>>>
>>>>>> The results suggest that "${WRKSRC}/configure" was modified, then
>>>>>> autoreconf regenerated ${WRKSRC}/configure afterwards so that the
>>>>>> pkgconfig path change was reverted.
>>>>>>
>>>>>> That's why I had to replace pathfix with MAKE_ARGS.
>>>>>
>>>>> No, USES=pathfix changes the content of PATHFIX_MAKEFILEIN, which by
>>>>> default, is Makefile.in. It won't change configure unless you set
>>>>> PATHFIX_MAKEFILEIN=configure.
>>>>>
>>>>
>>>> Well, I didn't add MAKE_ARGS for fun.
>>>> After adding USES+=autoreconf, the build broke. pathfix was still in
>>>> place. You can reproduce by adding pathfix back before "python" and
>>>> commenting out the new MAKE_ARGS line I added and check with
>>>> "check-plist" It's easy to confirm.
>>>
>>> I never said your fix did not work or was not right, I said USES=pathfix
>>> won't touch configure.
>>>
>>
>> Ah, that's the issue. I misspoke. I didn't mean "configure", I mean
>> the Makefile all along. So you agree in this case pathfix and
>> autoreconf aren't compatible, right?
>
> Not at all, if the file patched was Makefile.in, set
> PATHFIX_MAKEFILEIN=Makefile.am and it will work.
Okay, thanks, I learned something.
I think the current approach is cleaner anyway though.
John
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8cca7750-291e-c7c9-72aa-f91d17373046>