From owner-freebsd-hackers@FreeBSD.ORG Thu Jul 12 19:46:00 2012 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 37C91106566C; Thu, 12 Jul 2012 19:46:00 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay01.ispgateway.de (smtprelay01.ispgateway.de [80.67.31.28]) by mx1.freebsd.org (Postfix) with ESMTP id B62988FC16; Thu, 12 Jul 2012 19:45:59 +0000 (UTC) Received: from [84.44.178.238] (helo=fabiankeil.de) by smtprelay01.ispgateway.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1SpPJc-0003ty-FH; Thu, 12 Jul 2012 21:44:44 +0200 Date: Thu, 12 Jul 2012 21:44:30 +0200 From: Fabian Keil To: Andriy Gapon Message-ID: <20120712214430.02451df7@fabiankeil.de> In-Reply-To: <4FFF27F0.4000106@FreeBSD.org> References: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com> <4FFB4770.7050209@FreeBSD.org> <20120710154128.192eb8d6@fabiankeil.de> <1341939155.2573.8.camel@powernoodle.corp.yahoo.com> <20120710205702.5e57168b@fabiankeil.de> <4FFC8479.9080608@FreeBSD.org> <20120711122935.1382e76d@fabiankeil.de> <20120712201741.34573af4@fabiankeil.de> <4FFF2171.1030800@FreeBSD.org> <20120712213615.39640d1f@fabiankeil.de> <4FFF27F0.4000106@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/Z/ksMZsAI3ndvRbkTUKpQrZ"; protocol="application/pgp-signature" X-Df-Sender: Nzc1MDY3 Cc: freebsd-hackers@FreeBSD.org, Sean Bruno Subject: Re: dtraceall.ko with old nfsclient X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2012 19:46:00 -0000 --Sig_/Z/ksMZsAI3ndvRbkTUKpQrZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Andriy Gapon wrote: > on 12/07/2012 22:36 Fabian Keil said the following: > > Andriy Gapon wrote: > >=20 > >> on 12/07/2012 21:17 Fabian Keil said the following: > >>> Benjamin Kaduk wrote: > >>>=20 > >>>> On Wed, 11 Jul 2012, Fabian Keil wrote: > >>>>=20 > >>>>> I'm using the following modification of Sean's patch: > >>>=20 > >>> This way it seems to work as expected: > >>>=20 > >>> diff --git a/sys/modules/dtrace/dtraceall/Makefile=20 > >>> b/sys/modules/dtrace/dtraceall/Makefile index 456efd1..628583b 100644 > >>> --- a/sys/modules/dtrace/dtraceall/Makefile +++=20 > >>> b/sys/modules/dtrace/dtraceall/Makefile @@ -1,7 +1,7 @@ # $FreeBSD:=20 > >>> src/sys/modules/dtrace/dtraceall/Makefile,v 1.3 2011/04/09 09:07:31 u= qs > >>> Exp $ > >>>=20 > >>> KMOD=3D dtraceall -SRCS=3D dtraceall.c opt_compat.h > >>> +SRCS=3D dtraceall.c opt_compat.h opt_nfs.h > >>>=20 > >>> CFLAGS+=3D -I${.CURDIR}/../../.. > >>>=20 > >>=20 > >> If you do cd sys/modules/dtrace/dtraceall && make [obj depend] all, do= es > >> it compile OK with the above change? > >=20 > > Depends on your expectations I guess. As neither NFS-related option gets > > defined, no dependency on either NFS module is registered. The compiler= has > > no complaints, though. >=20 > Interesting. Could you repeat after sufficient cleaning up? > I am not sure where from opt_nfs.h file could come. The Makefile seems to create an empty one: =20 fk@r500 /usr/src/sys/modules/dtrace/dtraceall $make clean rm -f export_syms dtraceall.ko dtraceall.kld dtraceall.o dtraceall.ko.debug= dtraceall.ko.symbols opt_compat.h opt_nfs.h fk@r500 /usr/src/sys/modules/dtrace/dtraceall $make echo "#define COMPAT_FREEBSD32 1" >> opt_compat.h :> opt_nfs.h cc -O2 -pipe [...] -c /usr/src/sys/modules/dtrace/dtraceall/dtraceall.c ld -d -warn-common -r -d -o dtraceall.ko.debug dtraceall.o :> export_syms awk -f /usr/src/sys/modules/dtrace/dtraceall/../../../conf/kmod_syms.awk dt= raceall.ko.debug export_syms | xargs -J% objcopy % dtraceall.ko.debug objcopy --only-keep-debug dtraceall.ko.debug dtraceall.ko.symbols objcopy --strip-debug --add-gnu-debuglink=3Ddtraceall.ko.symbols dtraceall.= ko.debug dtraceall.ko Fabian --Sig_/Z/ksMZsAI3ndvRbkTUKpQrZ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk//KSsACgkQBYqIVf93VJ1LTgCgtm17ryTK9TMzX0+3dlfzwJ0P rxoAoK3gT3SlCrmWRvHUe0a2/GZvThsl =eJpo -----END PGP SIGNATURE----- --Sig_/Z/ksMZsAI3ndvRbkTUKpQrZ--