Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Mar 2016 14:02:47 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        marino@freebsd.org
Cc:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r411712 - in head/sysutils/rename: . files
Message-ID:  <20160328140247.GA27920@FreeBSD.org>
In-Reply-To: <56F2A825.8010703@marino.st>
References:  <201603231406.u2NE6VQa075069@repo.freebsd.org> <20160323142328.GA64753@FreeBSD.org> <56F2A825.8010703@marino.st>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 23, 2016 at 03:28:53PM +0100, John Marino wrote:
> On 3/23/2016 3:23 PM, Alexey Dokuchaev wrote:
> > > [ pkg-descr changes stripped ]
> >
> > There was nothing wrong with previous version, and it has nothing to do
> > with "update to 1.99.2" anyways, please reinstate it.
> 
> But there is nothing wrong with the current version either, so there's
> nothing to be gained by a commit war.
> 
> Plus I understand what he's doing, he's wrapping to 75 cols.  I can
> understand skipping the change in the PR stage, but now that it's
> committed, it should stay.  There's nothing to be gained by reverting
> it now.

See the problem here is that Kato won't listen to this, so while careful
committers would probably not revert these changes, it essentially gives
Kato carte blanche on pushing his changes, often overriding one's earlier
works.  I pay a great deal of attention when writing pkg-descr files, so
they are complete, spell-checked, and nicely formatted, and then comes
Kato and destroys my work just because he's wrapping to 75 cols. :-(

> Also, updating pkg-descr is valid any time, you don't need to limit
> it to strict version upgrades.

It does not have to limited, but when it happens it should be mentioned
in the commit log.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160328140247.GA27920>