From nobody Tue Sep 13 14:50:32 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MRmbx1K8Fz4cYKQ; Tue, 13 Sep 2022 14:50:37 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MRmbw2tt4z42Dh; Tue, 13 Sep 2022 14:50:36 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1663080635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jNeL1yUW9GvK/3s33YUtVsE+NB53igV4LJZFeDuNWB0=; b=V0e6F+rqn7HPL8DE7LSB+B9JvwMLWaZYUa7HfsvYETgWALusDc+a+nnmp1/GTg+9AHWtTC 5XGF53DvB9oWWreHdBr7ZMMJLWxHHDuB0ZbfAQZKVSNskXUPhoRd2ugevwyaLcreZv+Tdh kmaOCyAsnVu3sRWE6L+rCqcQ/Wvk3FA= Received: from skull.home.blih.net ( [94.238.214.231]) by mx.blih.net (OpenSMTPD) with ESMTPSA id f56c75e2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 13 Sep 2022 14:50:34 +0000 (UTC) Date: Tue, 13 Sep 2022 16:50:32 +0200 From: Emmanuel Vadot To: Jessica Clarke Cc: Mitchell Horne , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , John Baldwin Subject: Re: git: 10c6af344108 - main - bhyve: Fix build when BHYVE_SNAPSHOT is set Message-Id: <20220913165032.22c70870f754f26e00205dec@bidouilliste.com> In-Reply-To: <526E3D8E-895C-476E-BB7C-F2EE61DA456E@freebsd.org> References: <202209130632.28D6WdW9021176@gitrepo.freebsd.org> <9903ef54-80a9-67e6-f9ab-1371c42916ff@freebsd.org> <20220913163250.199f7ae9cf021249846a9133@bidouilliste.com> <526E3D8E-895C-476E-BB7C-F2EE61DA456E@freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MRmbw2tt4z42Dh X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, 13 Sep 2022 15:34:45 +0100 Jessica Clarke wrote: > On 13 Sept 2022, at 15:32, Emmanuel Vadot wrote: > >=20 > > On Tue, 13 Sep 2022 10:49:46 -0300 > > Mitchell Horne wrote: > >=20 > >>=20 > >>=20 > >> On 9/13/22 03:32, Emmanuel Vadot wrote: > >>> The branch main has been updated by manu: > >>>=20 > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D10c6af344108a8cfdc431b= 5b304de9c0fddcec47 > >>>=20 > >>> commit 10c6af344108a8cfdc431b5b304de9c0fddcec47 > >>> Author: Filipe da Silva Santos > >>> AuthorDate: 2022-09-13 06:30:41 +0000 > >>> Commit: Emmanuel Vadot > >>> CommitDate: 2022-09-13 06:32:09 +0000 > >>>=20 > >>> bhyve: Fix build when BHYVE_SNAPSHOT is set > >>>=20 > >>=20 > >> Can this option be added to LINT? > >>=20 > >> Mitchell > >=20 > > Probably should as it would have prevent this, but I'm not sure of why > > this is an option currently, John ? >=20 > It disables capsicum support as the two aren?t currently compatible. Oh ok. > Also, LINT wouldn?t help, this is userspace not the kernel. Yeah true, this part is. > Jess >=20 > >>=20 > >>> Fixes: 9cc9abf409cc ("bhyve: create all vcpus on startup") > >>> Sponsored by: Beckhoff Automation GmbH & Co. KG > >>> X-MFC-With: 9cc9abf409cc > >>> --- > >>> usr.sbin/bhyve/bhyverun.c | 1 - > >>> 1 file changed, 1 deletion(-) > >>>=20 > >>> diff --git a/usr.sbin/bhyve/bhyverun.c b/usr.sbin/bhyve/bhyverun.c > >>> index 550cc9d15477..27f1d8ea8892 100644 > >>> --- a/usr.sbin/bhyve/bhyverun.c > >>> +++ b/usr.sbin/bhyve/bhyverun.c > >>> @@ -1244,7 +1244,6 @@ main(int argc, char *argv[]) > >>> #ifdef BHYVE_SNAPSHOT > >>> char *restore_file; > >>> struct restore_state rstate; > >>> - int vcpu; > >>>=20 > >>> restore_file =3D NULL; > >>> #endif > >=20 > >=20 > > --=20 > > Emmanuel Vadot >=20 --=20 Emmanuel Vadot