From nobody Tue Aug 4 19:33:40 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hF3d00BMMz6nJP7 for ; Tue, 04 Aug 2026 19:33:56 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hF3cz3C0qz3M1J for ; Tue, 04 Aug 2026 19:33:55 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); arc=pass ("google.com:s=arc-20260327:i=1"); spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=asomers@gmail.com Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-69c600f76ccso256288a12.0 for ; Tue, 04 Aug 2026 12:33:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1785872033; cv=none; d=google.com; s=arc-20260327; b=rGlfWvLv+e4OpHOT6PvyuIO4zYVKQhgbuEpNLaBQLSzaDMVdXG7eBcpZU1mRum/zZF 9OoL8tJESoLDTzUUNxlQtcWVDU957zBiu6FKbgWmzfvgfS7hxezWJuSi8QsEWKg7/TOo aKxmL0eyIm+QJNnyTkAttw5aU85muQ7+7NIeeOVsRF90m/33R6Rcl9tU2w2hRB1UEA0E UtDb/+vpI3M/Nk99hribPRdlEZPJSpTntzNHXdqqhtLYi/ppc9YupGqSJV9Ipu5MsJUz 3LUUFPLRwXh5pDfPCy0b9kWGqB9sA3dGWUOk2/c9xMVSzl4sL8QYDIz6v7YbcEXmVCtI PFaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:subject:message-id:date:from :in-reply-to:references:mime-version; bh=ygcJFRDATa8NmowdrIsvOPWr49okIdgWsrsFO8Wc27o=; fh=OrhDtChR5ztm/HZXyq2hOGHX9zJeIaBJAnJIjQaFeY0=; b=Nzupzmh17/8UdX538ksseCT3i7V4hS18w5ytYEnKRNFn543lKElv6ZKzp4oSKD7Lth Kwxp+7J3G33hRDoi1dMpD1Qyiy0DIZpeGFkPYzaCA4FKiavIAVwU6fQbZK/f3AkXNlNF jq/c+TVfgtbwRoG+saR/2aEWKuqpV755tU90ieS586b2biMa2qrqTtkkHYF358zb5/Gc nZ4OKn1ELpydOJl7GwV4yNWtFmW9W8Ee/qtjS1fTb6+V6f7XfhsedTcY6bXDDLaUfwKm l7YC9S4JyCX3kg7yG3zUkTWzb7ImvYXXlcWLoMueO6CM+x7E5JAcDEu+xb6BWAuCoye1 jH9Q==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785872033; x=1786476833; h=content-transfer-encoding:content-type:cc:subject:message-id:date :from:in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=ygcJFRDATa8NmowdrIsvOPWr49okIdgWsrsFO8Wc27o=; b=sVkOEmBKNnoW2di41oqiSumk4IXl56HmLM3PbaykRSqILJxpmWgu2tAW7jZ5XCbag3 v+vMiCAZtmdD0ODNV3XlHfssCuIxxF77XCWsmxdsLCk+QbTy6gXlmzTqjnlVNUiUuxWZ 60rmBV0G33+gV55GdoKYIjEHZXj2B9ev3srRi+B6px8G6WzYBn8mD9ln7S5Tmo/23CON s4ejbRxs836GzBbeeOddvU6l7s6CnaUweSO7E3Pu9+gTfrBT7hddgPGYku5Rxhzqywvl d0g7J7A+MA+SgRBTZLyAAfxBLlvxLN3JgJBIiMsEdRmjbPPVks4pqPz4Q2x+hI0WNavv /v+g== X-Forwarded-Encrypted: i=1; AHgh+Rq1K68UlkJvEv41n+C5zYbR0GceCyc1byj9WMgqPao0SM0mct2nckYqanELb3PChbCfU6Xpj1mUV58e6p/i7MAxb20+0g==@freebsd.org X-Gm-Message-State: AOJu0YwVnBa+jwo0N3mM0I5tZWPymYFuxpCXigcln1yADp8zaWr8i6zr qlDfc2AlyEACkfWBGOOMhhDmjKVQy+hP59n7H5MAmYH3nja/iRjf4S53Uar/bjTQib++mwmugPi 5Zw8m6wgG8n23kDOxKl15ahfJn8yRRLk= X-Gm-Gg: AR+sD12DNKMhi+sRoVjdFndOAQD6PienjN/sSBVuCpip3pFyDsB/DOC+9c3oXzsmhSy 8l3uprBpd+tlZdQ8TqjZSW9jaTs2Kav4vC80hdAQB20KsS7MGGy8Q4KT/AyI/JcEa25918gIklW Wrj2g+xLGDbmKhAvDHzNFcLe3Y2vYR4YexOp00Px6aGKqVXA6+ZokWZVrlEWKA4QXL1AYpa7DOg fUneP3q+Yrdx1ueMx2q3DfP0ZDHDOwM/e5y0Yg6JcW73o7VM09MCMR/VFwTFUJhDDGT0YW21V3o soa/zFAqj1PYtuCNTpZi8MWMtzaymvfKryr29e/jaSpQoSQkOiLw/JQ9WJt6lWnBPP6qSxpn9/+ oPK0HUY/2HQZXCSCFIw/EnqhWkgQkAg== X-Received: by 2002:a05:6402:548a:b0:69c:72e2:a3d5 with SMTP id 4fb4d7f45d1cf-6a14f0a7b45mt731160a12.6.1785872032992; Tue, 04 Aug 2026 12:33:52 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a70e844.251cb.6995429f@gitrepo.freebsd.org> In-Reply-To: From: Alan Somers Date: Tue, 4 Aug 2026 13:33:40 -0600 X-Gm-Features: AUfX_myq14XJUxvhbmHGkCK_1ut80kLBZNF_wnamdTk6gpl-WbNtcXiow81yW90 Message-ID: Subject: Re: git: 4bd01d6ae016 - main - fts: refactor to use fd-relative operations internally Cc: Mark Johnston , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-1.73 / 15.00]; MISSING_TO(2.00)[]; ARC_ALLOW(-1.00)[google.com:s=arc-20260327:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.83)[-0.833]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; FREEFALL_USER(0.00)[asomers]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.41:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; RCVD_COUNT_ONE(0.00)[1]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.41:from]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4hF3cz3C0qz3M1J X-Spamd-Bar: - Try this patch. It works for me. I don't have an ATF regression test to go with it, though: diff --git a/lib/libc/gen/fts.c b/lib/libc/gen/fts.c index 204340e4b87f..3dd9b6432a2c 100644 --- a/lib/libc/gen/fts.c +++ b/lib/libc/gen/fts.c @@ -489,8 +489,7 @@ fts_read(FTS *sp) * FTS_STOP or the fts_info field of the node. */ if (sp->fts_child !=3D NULL) { - if (fts_safe_changedir(sp, p, - p->fts_dirfd, p->fts_name)) { + if (fts_safe_changedir(sp, p, -1, p->fts_name)) { p->fts_errno =3D errno; p->fts_flags |=3D FTS_DONTCHDIR; for (p =3D sp->fts_child; p !=3D NULL; On Tue, Aug 4, 2026 at 1:00=E2=80=AFPM Alan Somers wr= ote: > > On Tue, Aug 4, 2026 at 12:58=E2=80=AFPM Mark Johnston = wrote: > > > > On Mon, Aug 03, 2026 at 07:13:08PM +0000, Alan Somers wrote: > > > The branch main has been updated by asomers: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D4bd01d6ae01632501b6343= 8b8d9a401db9744a78 > > > > > > commit 4bd01d6ae01632501b63438b8d9a401db9744a78 > > > Author: Jitendra Bhati > > > AuthorDate: 2026-06-12 17:07:55 +0000 > > > Commit: Alan Somers > > > CommitDate: 2026-08-03 19:12:28 +0000 > > > > > > fts: refactor to use fd-relative operations internally > > > > > > Replace all _open() calls with _openat() in __fts_open(), fts_rea= d(), > > > and fts_children(). Replace statfs() with _fstatfs(). > > > > > > Add fts_dirfd to struct _ftsent, set to the file descriptor of th= e > > > parent directory. Callers can use openat(ent->fts_dirfd, ent->fts= _name, > > > ...) to access files safely without relying on fts_accpath, which > > > enables programs in capability mode to open the files described b= y > > > _ftsent. > > > > > > This is a preparatory change for fts_openat() which will allow ca= llers > > > to provide a pre-opened directory fd, enabling fts(3) traversal i= nside > > > Capsicum capability mode. > > > > > > Mirror all fts_open() changes to fts_open_b(). > > > > > > As a result of expanding _ftsend, publish new ELF symbol versions= for > > > fts_openat and related functions. > > > > > > Sponsored by: Google LLC (GSoC 2026) > > > Reviewed by: asomers > > > Pull Request: https://github.com/freebsd/freebsd-src/pull/2303 > > > > Quite a few regression tests seem to be failing after this commit, e.g.= , > > some of the makefs tests: https://ci.freebsd.org/job/FreeBSD-main-amd64= -test/29201/ > > I'm testing a fix now. I should have something ready for you soon.