Date: Thu, 10 Jan 2013 01:45:26 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Jaakko Heinonen <jh@freebsd.org>, src-committers@freebsd.org, pjd@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, imp@freebsd.org Subject: Re: svn commit: r244585 - in head: . sys/geom/label Message-ID: <20130109234526.GL2561@kib.kiev.ua> In-Reply-To: <201301091417.37451.jhb@freebsd.org> References: <201212221343.qBMDhCHa086834@svn.freebsd.org> <201301070927.07157.jhb@freebsd.org> <20130108193146.GA1815@a91-153-116-96.elisa-laajakaista.fi> <201301091417.37451.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--QWRRbczYj8mXuejp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 09, 2013 at 02:17:37PM -0500, John Baldwin wrote: > On Tuesday, January 08, 2013 2:31:47 pm Jaakko Heinonen wrote: > > On 2013-01-07, John Baldwin wrote: > > > I think if it isn't hard to do so, we should aim to preserve labels a= s they=20 > > > are generally intended to be human readable as-is. Just preserving s= paces is=20 > > > probably sufficient for this as they are probably the most commonly u= sed=20 > > > character in labels affected by this change. > >=20 > > All right. I have prepared patches for review. > >=20 > > - Quote device names in devctl(4) device events. This allows events to > > work for device names containing spaces. > > - Allow spaces again in device names. > >=20 > > Requested by: jhb > > PR: kern/161912 >=20 > Thanks. I think your patches look fine as far as I can tell. I do not object, but IMHO having names with the spaces in /dev is weird and possibly problematic. This was the reason of my initial request to disable spaces, together with the fact that it changes the devctl(4) protocol (there might be other /dev/devctl readers besides devd). --QWRRbczYj8mXuejp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQ7gEWAAoJEJDCuSvBvK1BeTwP/1Epv5nTcwLFbAkn9Td5naB2 R+4iYsu+E7qEG0Li2paH9m3LcPOZab/NLsjoHLe7xAvEpwdyKQuJjvWsOyn2JmGh Z7nvZ3mbjdP8v8OymRSKPHHP6lee6Mt4b0UnppseRfWEbtjNWJIGCc9XdxtlsPRN 1lNX0Tu3toh7RAY8zFIHlNU9muyyb3E2MWgYlnokyouebHSXwKLBRHo2eGwa5kRy AZIDudCy++T0DTx6pZ0qPkEARxNoowgmXY22VJD0K8iqwtmhu5EM/yziKQFN8vKt JVSKUutOQhVa64rJrsHRPoQgz/XZzWBzK94jdjEjz7f5nF6ICg8lf8v1iMuCvr2C 8UcSEf6ktfoh2sLUEysWgK4uVS3Zv16w0Ub87y+i+V4tbHQfiQI29hcJ4dMd04I/ ZYZYrgA6dGWi8SoihnUzdGvFxxApRNtLmxopaNGvqWhX3XH8rFn3NRO6V5VfChS4 XyQ+ub+tLQKjxFTxgQAkviC3uz1uI7tnfKm6ld4Ai5IaZOSd9t9mjCPC5lDFuuw2 UVxOsOKw885NQEuqLs0s8jrxs60OQgWetWkY2zr0EY9v9zOwxE4Uis0SxsARv9LT xf1/Pe3zxHofhdD3znvaOe2T3uZpb4VfDSJpza1js5K+hag4xGhR2XjjkpuaabzV R/IV3OvAAenwiD0TCnRG =vDZ2 -----END PGP SIGNATURE----- --QWRRbczYj8mXuejp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130109234526.GL2561>