From owner-dev-commits-src-all@freebsd.org Wed Dec 30 01:00:38 2020 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E69D14D0AA8; Wed, 30 Dec 2020 01:00:38 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D5CdL61gnz3thp; Wed, 30 Dec 2020 01:00:38 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qk1-f169.google.com with SMTP id h4so12905239qkk.4; Tue, 29 Dec 2020 17:00:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+yNFOdVgGztdWkwFYLFx4xuyZCRAGIxeDgb8udcbaqU=; b=L3XzXqp1VlF301BYlQjrbXssoAcIc1uD/EM2Ii6QrGJtAv7cyoES1SXsQ5yVyx7KBV d2uTO+HVGlaQKVzCySFkeJLozqnSCfWxSfuH92y1mZUCi8x3umc5qPqBtdiqmkD432nX JHj3ZSQAJL+j5Ek/XdJFXPGad7GJRv0GZWQH/t79FqGtaNtLqQYfIX7XbXzj2qsbVCGH FxpQYwBwknqETm40TT33hiHRMc0ignI6X3q8IUIF0Jq0iVsCpRniXvFo+xuhapQVZ3si s9ohjHZDR1KmlkwqzE6jqi0xvLBVd+P3pAmhaldEKOUwEalVgVaf7Zgqf6MVy7VUJ11l bbFQ== X-Gm-Message-State: AOAM531Q8mhWD0tuc7j9Cm2R8RfuOn0YrFdseoG/KT67V+NnV4oC6uJJ +d18HMFqm/GHiYMxBUl2A/YNV/y0trjPPQ== X-Google-Smtp-Source: ABdhPJzDrSByZwcp6OFvmua5VkSSNiTitjWLAkME5ATPNVO/MCkAHrM2AcqFiV0eiUQ3ZeE0J2UQug== X-Received: by 2002:a37:aa42:: with SMTP id t63mr50325564qke.271.1609290037331; Tue, 29 Dec 2020 17:00:37 -0800 (PST) Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com. [209.85.219.42]) by smtp.gmail.com with ESMTPSA id r6sm27469862qkk.127.2020.12.29.17.00.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Dec 2020 17:00:37 -0800 (PST) Received: by mail-qv1-f42.google.com with SMTP id l14so7144328qvh.2; Tue, 29 Dec 2020 17:00:37 -0800 (PST) X-Received: by 2002:ad4:57ab:: with SMTP id g11mr54673920qvx.38.1609290036929; Tue, 29 Dec 2020 17:00:36 -0800 (PST) MIME-Version: 1.0 References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Tue, 29 Dec 2020 17:00:26 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 To: Kyle Evans Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D5CdL61gnz3thp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for all branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2020 01:00:39 -0000 On Tue, Dec 29, 2020 at 4:53 PM Kyle Evans wrote: > > On Tue, Dec 29, 2020 at 6:50 PM Kyle Evans wrote: > > > > On Tue, Dec 29, 2020 at 6:38 PM Ryan Libby wrote: > > > > > > On Tue, Dec 29, 2020 at 3:32 PM Kyle Evans wrote: > > > > > > > > Hmm, I hadn't done this because we still have in-tree GCC4.2. Might want to go ahead and skip these tests entirely a level up for 4.2. > > > > > > > > > > Ah, thanks for the reminder. I'll take another look re in-tree gcc. > > > Based on the other commits I've MFC'd, I'm pretty sure it's been > > > broken for months anyway, but I'll see what I can do if the fixes are > > > easy. > > > > > > > This should not be the case, we've been running arm/mips/etc. in CI up > > until the git transition. > > Sorry, arm is irrelevant for this branch- but mips/powerpc/sparc64. Perhaps only x86 was broken... How was tftpd/tests not already broken with alignas from r367305 which MFC'd r358556? In any case my plan right now is to try to remember the gcc 4.2 voodoo, assess, and fix. Please let me know if you think this needs immediate revert before then. Ryan