From owner-freebsd-hackers@FreeBSD.ORG Wed Aug 14 17:17:35 2013 Return-Path: Delivered-To: hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D7897B1A; Wed, 14 Aug 2013 17:17:35 +0000 (UTC) (envelope-from ryao@gentoo.org) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 77070288B; Wed, 14 Aug 2013 17:17:35 +0000 (UTC) Received: from [192.168.1.2] (pool-173-52-119-53.nycmny.fios.verizon.net [173.52.119.53]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: ryao) by smtp.gentoo.org (Postfix) with ESMTPSA id 94B8F33EA97; Wed, 14 Aug 2013 17:17:28 +0000 (UTC) Message-ID: <520BBB91.4010209@gentoo.org> Date: Wed, 14 Aug 2013 13:17:05 -0400 From: Richard Yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130714 Thunderbird/17.0.7 MIME-Version: 1.0 To: Steven Hartland Subject: Re: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ Agility 2 References: <1376223145-81081-1-git-send-email-ryao@gentoo.org> In-Reply-To: X-Enigmail-Version: 1.6a1pre Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2JGBTUTDXAIXHUGNSGMVV" Cc: hackers@FreeBSD.org, Eitan Adler X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 17:17:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JGBTUTDXAIXHUGNSGMVV Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I neglected to include the CC list on the previous email that I sent, so here is a reproduction: I am afraid that is not possible. I extracted the "MARVELL SD88SA02" entry from Open Solaris. The OCZ Agility 2 entry was provided by another Gentoo developer using a tool that performed an inquiry query and extracted the exact 24 bytes in the combined vendor/product identification fields. The same was done for the X25-M. I actually do own one of those and could get FreeBSD running on that machine, but Artem Belevich has already responded with that information. On 08/13/2013 10:02 PM, Steven Hartland wrote: > Could you provide the output from camcontrol identify for these > disks I want to just double check the formatting before commiting as I > don't have these disks here in labs. >=20 > Regards > Steve >=20 > ----- Original Message ----- From: "Richard Yao" > To: > Cc: "Richard Yao" ; "Eitan Adler" = > Sent: Sunday, August 11, 2013 1:12 PM > Subject: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ= > Agility 2 >=20 >=20 >> Signed-off-by: Richard Yao >> --- >> sys/cam/ata/ata_da.c | 24 ++++++++++++++++++++++++ >> sys/cam/scsi/scsi_da.c | 24 ++++++++++++++++++++++++ >> 2 files changed, 48 insertions(+) >> >> diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c >> index f201231..b7f293d 100644 >> --- a/sys/cam/ata/ata_da.c >> +++ b/sys/cam/ata/ata_da.c >> @@ -349,6 +349,14 @@ static struct ada_quirk_entry ada_quirk_table[] =3D= >> }, >> { >> /* >> + * Intel X25-M Series SSDs >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> * Kingston E100 Series SSDs >> * 4k optimised & trim only works in 4k requests + 4k aligned >> */ >> @@ -365,6 +373,22 @@ static struct ada_quirk_entry ada_quirk_table[] =3D= >> }, >> { >> /* >> + * Marvell SSD (entry taken from Open Solaris) >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> + * OCZ Agility 2 SSDs >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> * OCZ Agility 3 SSDs >> * 4k optimised & trim only works in 4k requests + 4k aligned >> */ >> diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c >> index 617afbd..df895be 100644 >> --- a/sys/cam/scsi/scsi_da.c >> +++ b/sys/cam/scsi/scsi_da.c >> @@ -1008,6 +1008,14 @@ static struct da_quirk_entry da_quirk_table[] =3D= >> }, >> { >> /* >> + * Intel X25-M Series SSDs >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> * Kingston E100 Series SSDs >> * 4k optimised & trim only works in 4k requests + 4k aligned >> */ >> @@ -1024,6 +1032,22 @@ static struct da_quirk_entry da_quirk_table[] =3D= >> }, >> { >> /* >> + * Marvell SSD (entry taken from Open Solaris) >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> + * OCZ Agility 2 SSDs >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> * OCZ Agility 3 SSDs >> * 4k optimised & trim only works in 4k requests + 4k aligned >> */ >> --=20 >> 1.8.1.5 >> >> _______________________________________________ >> freebsd-hackers@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers >> To unsubscribe, send any mail to >> "freebsd-hackers-unsubscribe@freebsd.org" >> >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > This e.mail is private and confidential between Multiplay (UK) Ltd. and= > the person or entity to whom it is addressed. In the event of > misdirection, the recipient is prohibited from using, copying, printing= > or otherwise disseminating it or any information contained in it. > In the event of misdirection, illegible or incomplete transmission > please telephone +44 845 868 1337 > or return the E.mail to postmaster@multiplay.co.uk. >=20 ------enig2JGBTUTDXAIXHUGNSGMVV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSC7uUAAoJECDuEZm+6Exk8E8P/R8NdfZmkONsOO7xIaryrWGT P3KHdHFS5iTZvqfEjnSkvpH/8irlBY2L6ld9MifP/yZyKZxb+yIDNCIsettZG8Bu pgpVebGeNmumzQAR/NY3NNyZxnYBjP2nhZaVJVIAu0I/WRrtgCIiHfGQruQ9Olp+ UxBU3qdaZG//FpFq9uWugjVG/iag2R6HgZfHnPqygRHB6yqj83xVSxVT8K32KkIe vGus6wFr0H54qWIfNnbYQlKrSVKd8OPo+/XyOByKWgCys+609IyX/xiVWjHR2/ey 4/Ax11EpRBGv+tMp8yVmL0OL+pBlPS2MtCCkkaHd6Va63TtwNxW5RJIygD8gD5cO FOmHgXL4diX6NXU9xqBe5+yido8WPQ5cMz9dQPNVpdswfjnv3DLa+orSItaplAbi TZxN2C9h7TO/r9u8FVZwt7+MQqhP7JUZj0oG4/g+xrQoORTdGikmZroQ8zaETeaC Lr3YN4y8dpf4tLsPBG5PBVVvr0TVharxEBJ0edlzyGqpTZprJUT+9YDvsxKdVuDU NsaKrChHyC1iKC1SYjhm1GSwcKzTdE4ZhEnRlPSLFM3wN0Zs/Gb8awyO6Hq3huNr fqFoFiTmNug7oSkZGV/8kJWmbFYqAXtHYNFC168EhfMq7rVKGRZ/UiELb2QxWWO/ bWVa2DPNQQJ2/V9W7wf4 =gWSA -----END PGP SIGNATURE----- ------enig2JGBTUTDXAIXHUGNSGMVV--