From nobody Fri Sep 1 00:32:24 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RcJrn24HVz4rpnh for ; Fri, 1 Sep 2023 00:32:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RcJrn13X7z3d0Q for ; Fri, 1 Sep 2023 00:32:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693528345; a=rsa-sha256; cv=none; b=VNrHFS6OBdwylOCDuyOWjl5mOuLlqFZrW5BX3pp6BHQwbbJaY7BEngCu/4fcwx9+qMNp4T QHw4tnxmH90mQHcHtWGNs9olKpK42laLiB1x93btttzSvHmh9rgv/KPwRAeZWqo87t1Q6V QZlMEglvGJbSkfw6xOTlMF9SkgfZNKYfCHXsvHowCycBp1KBXTdRHS7lvoCp3Y55AL5InY 70cKPaLeYk8pHQn4lWRDLB/rB/3JnAmyYnNgbiABwgzZBjxMNCHis65qiycZFKAsqVTwJv YncQH9uIBTo7A9dxPkThajgZ+OzvlRqw+MPdJFKwjs/lde5rAyEKvM6dfPuDng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693528345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P5NOlZ+ffjDEygpCQEQ09iWykF37GZ3pBeICssnhoAA=; b=B7AXUPWLA4a+wADIEaw3lEWXR+bfmIXCGv0CiQc77qd9YV9WHeBcAJXYP7lFpu1kCbx7IS 2M7M3/4t1AxX0K/NDiU3fQpBafwxQ+qutkZGONKNR27cHAvCQawtinYnDasAoGsp3AspCd 74mVIypqmTLYmxuM4lA61NBJ5pqfbx63bxmSaJTPgspRAF84hA1Hi0/8SYMBg8qyutseJE AgdatRx6e/D5ih841TCrLjv1INZbFFKxWr6efZ1W/6s54Me05DPq6xeeLOJJNB6lHct8NB l/9Spp8J4q0IxOQkJJf62QMMPO8FzBsZlmr8yaCI4TS6/W6H1Vbz/9EGm5Imbg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RcJrn07gFzfm2 for ; Fri, 1 Sep 2023 00:32:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3810WOUW061894 for ; Fri, 1 Sep 2023 00:32:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3810WOqJ061893 for bugs@FreeBSD.org; Fri, 1 Sep 2023 00:32:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 212716] recv() with MSG_WAITALL doesn't always unblock on EOF Date: Fri, 01 Sep 2023 00:32:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: greg@codeconcepts.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212716 --- Comment #11 from Greg Becker --- Thanks Mark, agreed. I've moved the check up to the pr_rcvd'd block and ma= de it contingent upon sb_mb being NULL (which is what I was trying to leverage= in the original patch), and that seems to be working well. I've also added a KASSERT to sbwait() as suggested. Haven't tripped it yet, but I expect we'll want to thoroughly test it. I'll post the patch in a bi= t, but I want to spend some more time investigating soreceive_generic() for any holes where it might bail out having not delivered all available data first. --=20 You are receiving this mail because: You are the assignee for the bug.=