From owner-freebsd-ports-bugs@freebsd.org Wed Jul 5 16:13:58 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60742D87A72 for ; Wed, 5 Jul 2017 16:13:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DD521FC9 for ; Wed, 5 Jul 2017 16:13:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v65GDvZY024181 for ; Wed, 5 Jul 2017 16:13:58 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220361] [MAINTAINER] [PATCH] textproc/ripgrep: Add Bash, Fish and Zsh completions Date: Wed, 05 Jul 2017 16:13:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tobik@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 16:13:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220361 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org Status|New |Open Assignee|freebsd-ports-bugs@FreeBSD. |tobik@freebsd.org |org | --- Comment #1 from Tobias Kortkamp --- Yes, completion files would be great :) A couple of nitpicks below. I added the Unlicense to bsd.licenses.db.mk in ports r445082 which means your patch does not currently apply anymore. The license block can now be simplified to: LICENSE=3D MIT UNLICENSE LICENSE_COMB=3D dual LICENSE_FILE=3D ${WRKSRC}/COPYING LICENSE_FILE_MIT=3D ${WRKSRC}/LICENSE-MIT LICENSE_FILE_UNLICENSE=3D ${WRKSRC}/UNLICENSE +.include Please remove this again. It's not needed if you replace all `.if ${PORT_OPTIONS:MXXX}` with extra targets like post-install-XXX-on. See [1]. ${WRKDIR}/target/release/build/ripgrep-*/out should be changed to ${CARGO_TARGET_DIR}/*/build/ripgrep-*/out since it might not be 'release' but 'debug' when you compile the port WITH_DEBUG=3Dyes. Is there maybe a way to coerce the build to output the completion files to another directory? [1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html= #options-targets --=20 You are receiving this mail because: You are the assignee for the bug.=