From owner-freebsd-current@FreeBSD.ORG Thu Feb 27 06:18:41 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C9010451 for ; Thu, 27 Feb 2014 06:18:41 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A69B91B00 for ; Thu, 27 Feb 2014 06:18:41 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s1R6IeS4048715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 26 Feb 2014 22:18:41 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s1R6Iee2048714; Wed, 26 Feb 2014 22:18:40 -0800 (PST) (envelope-from jmg) Date: Wed, 26 Feb 2014 22:18:40 -0800 From: John-Mark Gurney To: Kohji Okuno Subject: Re: kqueue for KBD. Message-ID: <20140227061840.GB47921@funkthat.com> Mail-Followup-To: Kohji Okuno , freebsd-current@freebsd.org References: <20140227.142445.47188371497615592.okuno.kohji@jp.panasonic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140227.142445.47188371497615592.okuno.kohji@jp.panasonic.com> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Wed, 26 Feb 2014 22:18:41 -0800 (PST) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2014 06:18:41 -0000 Kohji Okuno wrote this message on Thu, Feb 27, 2014 at 14:24 +0900: > I tried to add kqueue I/F to kbd.c. I attached patch. > What do you think about my patch? So, knlist_destroy is missing in this patch too.. It also needs some style(9) loving in that some blank lines are missing and there are some extra curly braces... So, knlist_clear is usually used for something like close where it cannot be used again... You use knlist_clear when the kbd goes away, but this also means that the user will never be notified that the kbd has gone, and could possibly end up leaking resources... I guess I should maybe write a function knlist_clearerr or something that detaches all the knotes from the knlist and sets the proper flag so that they can be reaped by userland... I believe your usb patch had a similar issue and some of the other drivers have this issue too.. Otherwise looks good... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."