Date: Sun, 18 Feb 2024 15:01:29 +0300 From: Max Brazhnikov <makc@freebsd.org> To: Neel Chauhan <nc@freebsd.org>, Nuno Teixeira <eduardo@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ca21dddc0e31 - main - graphics/libnsgif: Update to 1.0.0 Message-ID: <2911916.SSXfckUlLJ@mercury> In-Reply-To: <CAFDf7UKu=kTdmSM%2Bd08oRxd05eRnndwKQWGLBGBibRPrjWrHrA@mail.gmail.com> References: <202402161824.41GIOgvd075302@gitrepo.freebsd.org> <CAFDf7UKu=kTdmSM%2Bd08oRxd05eRnndwKQWGLBGBibRPrjWrHrA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi all, On Sat, 17 Feb 2024 07:26:22 +0000 Nuno Teixeira wrote: > Did you do a consumers test? >=20 > -include/libnsgif.h > +include/nsgif.h >=20 > graphics/imv: > ../src/backend_libnsgif.c:9:10: fatal error: 'libnsgif.h' file not found > 9 | #include <libnsgif.h> >=20 > Any clues on recomended way to fix? >=20 > Neel Chauhan <nc@freebsd.org> escreveu (sexta, 16/02/2024 =C3=A0(s) 18:24= ): > > > > The branch main has been updated by nc: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dca21dddc0e31a6be1db1f5= 966a283f52d89cddf5 > > > > commit ca21dddc0e31a6be1db1f5966a283f52d89cddf5 > > Author: Neel Chauhan <nc@FreeBSD.org> > > AuthorDate: 2024-02-16 17:42:44 +0000 > > Commit: Neel Chauhan <nc@FreeBSD.org> > > CommitDate: 2024-02-16 18:24:27 +0000 > > > > graphics/libnsgif: Update to 1.0.0 > > --- > > graphics/libnsgif/Makefile | 2 +- > > graphics/libnsgif/distinfo | 6 +++--- > > graphics/libnsgif/files/patch-Makefile | 10 ---------- > > graphics/libnsgif/pkg-plist | 4 ++-- > > 4 files changed, 6 insertions(+), 16 deletions(-) > > > > diff --git a/graphics/libnsgif/Makefile b/graphics/libnsgif/Makefile > > index 09c07dda9f9a..7e0697f3b78c 100644 > > --- a/graphics/libnsgif/Makefile > > +++ b/graphics/libnsgif/Makefile > > @@ -1,5 +1,5 @@ > > PORTNAME=3D libnsgif > > -PORTVERSION=3D 0.2.1 > > +PORTVERSION=3D 1.0.0 > > CATEGORIES=3D graphics > > MASTER_SITES=3D http://download.netsurf-browser.org/libs/releases/ > > EXTRACT_SUFX=3D -src.tar.gz skip > > diff --git a/graphics/libnsgif/pkg-plist b/graphics/libnsgif/pkg-plist > > index 38365be87a3a..927929719b65 100644 > > --- a/graphics/libnsgif/pkg-plist > > +++ b/graphics/libnsgif/pkg-plist > > @@ -1,5 +1,5 @@ > > -include/libnsgif.h > > +include/nsgif.h > > lib/libnsgif.so > > -lib/libnsgif.so.0 > > +lib/libnsgif.so.1 > > lib/libnsgif.so.%%VERSION%% > > libdata/pkgconfig/libnsgif.pc What was the reason for this commit? Changes like this require from the maintainer to test consumer ports. Reque= st exp-run if you can't test all consumers locally, notify other maintainer= s about the change (exp-run won't catch all cases), ask for help if you nee= d it. To me committing untested stuff that breaks other ports is disrespect= ful to fellow maintainers and users. Cheers, Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2911916.SSXfckUlLJ>