From nobody Wed Aug 13 16:21:39 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c2DCT1RRRz647kq; Wed, 13 Aug 2025 16:21:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c2DCT0ZSnz3pf1; Wed, 13 Aug 2025 16:21:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755102101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RAK2QYHf80uDXtxzfKwY7AOth9Ng+zDkHH9Q4SYhWc8=; b=q1ChmIxBKC47RhBdF3Hru0qK5nd4p0MJwAQV1RlOJAQgTSZrlEt3Iy6DscNm6G2a/H9/il smquVRdfZJOgHOJWe73jrAgkplV0b9r+zJQbNnDOGgbvVLMLC00ZVzbZsV4t90emnWJyGa +Yxizom9VTW34mLLPazux4oUfrAcMhvvm4CYoordl8d//NTvnWv8lxlbdqe+a4bEyhmGbA nhHz7or67PHo5kpNFMUYZwr1vGDoRbQuMnfooh8tHqxWnIozhQjleGnC2PrbSTjk9v9nAJ tP2CpkAY39P8Rm3CzwfAGhdAzveNucEX3RAybQrqB9ILBkE6SKMdvk1O9br4Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755102101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RAK2QYHf80uDXtxzfKwY7AOth9Ng+zDkHH9Q4SYhWc8=; b=HifEfsVJeNz9l3HSCDK3a5AeNVgL5h4iOEQU158ikIZLEF1SxiA03sls4rPDUauoy9cg6X DimXywW5FgClqYNMKWUTJdLHYSYEV1U/3Zjl1l2g/1tBa00nWJDHDEUYG8rg8gNIO+lXuW VMNw+lIDLG+CY21JW64/OmXJkfW+HaEMWKVcscZMGP33mruACbJApTFEiQxGesnZP3fcXg HLhJxaPSrYF5PpDVnmiodkhWKhaGqCegRwlwIhyD9Pq/JRLNTgKNoul8qtb9lN6w30VM5K qBBrD9QyZ0276js+/lw9qx5MXs7PwthTwScxxgW6jgC67jRX8puJwNz5EurVuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755102101; a=rsa-sha256; cv=none; b=GMYHsR63NFql8fB068KfDS6KQtxKC2ApgWHhKFzMQbJWP5a9xEP+344vlPOYm2RfymtQCY rh/CEcwzHbpssqAyOum6CEXxDjkaeAk0+pzge3m/OX3ObY7ObKYrEpm5dnFNjX7kYWWSq5 Grd0pHxQ7oKthqXXqa5Jiw9AZkwNBLNhJ3Kuf4ePyPfvHmGWx+8fn/+MnSfRBtda5uO890 xpeOv3UtkbdcpQYBy3gbZc/yrXa4SbaAt7AU+ly7HfybtdgWK9DpynPxbwrRaSBFtxvFLF EddhROgMhodM1XDeTI6NuJ+WMkSvVFZ7uOsmfDdN8YXLrlyhI+L3P4lw8/FBNw== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c2DCS4pDzz1GDZ; Wed, 13 Aug 2025 16:21:40 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <13572e72-c061-4c89-82e0-0b72bf833cb5@FreeBSD.org> Date: Wed, 13 Aug 2025 11:21:39 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: babab49eee94 - main - chroot: don't setgroups() without -G having been specified To: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202508121230.57CCUuHn045783@gitrepo.freebsd.org> Content-Language: en-US From: Kyle Evans In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/12/25 23:14, Philip Paeps wrote: > On 2025-08-12 12:30:56 (+0000), Kyle Evans wrote: >> The branch main has been updated by kevans: >> >> URL: https://cgit.FreeBSD.org/src/commit/? >> id=babab49eee9472f628d774996de13d13d296c8c0 >> >> commit babab49eee9472f628d774996de13d13d296c8c0 >> Author:     Kyle Evans >> AuthorDate: 2025-08-12 12:14:38 +0000 >> Commit:     Kyle Evans >> CommitDate: 2025-08-12 12:30:23 +0000 >> >>    chroot: don't setgroups() without -G having been specified >> >>    We previously would not have setgroups() at all, but now we would drop >>    our supplementary groups every time.  This broke chroot -n, probably >>    among other things.  We need tests here, but lets unbreak things >> first. >> >>    A future change may try to setgroups(2) when -u is specified in >> addition >>    to -G, so predicate the call on gidlist and don't populate that >> without >>    a grouplist. >> >>    PR:             288751 >>    Fixes:  48fd05999b0f ("chroot: don't clobber the egid [...]") > > Thank you! > > This made the FreeBSD-kmods builds happy again. :) > Excellent, thanks for confirming! Sorry for the breakage-