From owner-freebsd-ports@FreeBSD.ORG  Thu Dec  7 18:30:47 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4941016A4C2;
	Thu,  7 Dec 2006 18:30:47 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7ED9743CFC;
	Thu,  7 Dec 2006 18:29:20 +0000 (GMT)
	(envelope-from wxs@atarininja.org)
Received: by syn.atarininja.org (Postfix, from userid 1001)
	id F00D75C58; Thu,  7 Dec 2006 13:31:03 -0500 (EST)
Date: Thu, 7 Dec 2006 13:31:03 -0500
From: Wesley Shields <wxs@atarininja.org>
To: ports@freebsd.org, Doug Barton <dougb@FreeBSD.org>
Message-ID: <20061207183103.GA73597@atarininja.org>
References: <45749998.3070308@FreeBSD.org>
	<20061204232125.GA42307@atarininja.org>
	<790a9fff0612050838s66c655fapfde80d4038f64ca2@mail.gmail.com>
	<20061205172803.GA51892@atarininja.org>
	<4575C568.70905@FreeBSD.org>
	<20061205194146.GC52966@atarininja.org>
	<20061205203120.GA53894@atarininja.org>
	<4575EBA8.3020601@FreeBSD.org>
	<BDBB52B0-3FB2-4C82-A507-4785183B3C1F@FreeBSD.org>
	<20061206014049.GA43656@atarininja.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061206014049.GA43656@atarininja.org>
User-Agent: Mutt/1.5.13 (2006-08-11)
Cc: 
Subject: Re: distfile belongs to?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Dec 2006 18:30:47 -0000

On Tue, Dec 05, 2006 at 08:40:49PM -0500, Wesley Shields wrote:
> On Tue, Dec 05, 2006 at 05:08:45PM -0800, Ade Lovett wrote:
> > 
> > On Dec 05, 2006, at 13:59 , Doug Barton wrote:
> > 
> > >Wesley Shields wrote:
> > >>>@comment DISTFILE:$filename:$size:$md5:$sha256
> > >
> > >I think that's good, the other information might come in handy down
> > >the road. One thing you might want to consider is to put the md5 sum
> > >at the end, since at some point down the road (maybe years from now,
> > >but still ...) we're likely to drop md5 altogether.
> > 
> > Better still would be:
> > 
> > @comment DISTFILE:<filename>[':' <key>=<value>]*
> > 
> > eg:  DISTFILE:foo:SIZE=1234:MD5=...:SHA256=...
> > 
> > Relying on the specific position of an item in a delimited list  
> > almost always comes back and bites in painful spots later on down the  
> > way.  Minimal extra parsing required by consumers, and bits and  
> > pieces can be added/removed almost at will.
> > 
> > -aDe
> 
> I agree.  I'll modify Doug's latest patch to add this.

I've reworked the two patches to take all of the suggestions in.

Part 1 (the pkg_info piece):

- Silently ignores the -F flag when distfile information is not recorded
  in +CONTENTS.
- Prints the information out in a human readable format (still respects
  -q).

Part 2 (the bsd.port.mk piece) is the patch posted by Doug with Ade's
suggestions.

The entire thing no longer requires a change to pkg_create in order to
function.  Anymore thoughts/comments/ideas before I send-pr these?

http://www.atarininja.org/~wxs/patches/package-distinfo-part1.diff
http://www.atarininja.org/~wxs/patches/package-distinfo-part2.diff

-- WXS