From owner-cvs-all  Mon Jul 23 18:30:57 2001
Delivered-To: cvs-all@freebsd.org
Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6C65737B403; Mon, 23 Jul 2001 18:30:47 -0700 (PDT)
	(envelope-from drosih@rpi.edu)
Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47])
	by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f6O1UkL155028;
	Mon, 23 Jul 2001 21:30:46 -0400
Mime-Version: 1.0
X-Sender: drosih@mail.rpi.edu
Message-Id: <p0510100db7827da58818@[128.113.24.47]>
In-Reply-To: <20010724090813.M55779@wantadilla.lemis.com>
References: <200107231205.f6NC5R526236@freefall.freebsd.org>
 <200107231103.f6NB3mi10592@freefall.freebsd.org>
 <200107231100.f6NB0Wm05549@freefall.freebsd.org>
 <20010724090813.M55779@wantadilla.lemis.com>
Date: Mon, 23 Jul 2001 21:30:44 -0400
To: Greg Lehey <grog@FreeBSD.org>, Kris Kennaway <kris@FreeBSD.org>
From: Garance A Drosihn <drosih@rpi.edu>
Subject: Re: cvs commit: src/libexec/atrun atrun.c
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Content-Type: text/plain; charset="us-ascii" ; format="flowed"
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

At 9:08 AM +0930 7/24/01, Greg Lehey wrote:
>On Monday, 23 July 2001 at  5:05:27 -0700, Kris Kennaway wrote:
>>  kris        2001/07/23 05:05:27 PDT
>>    Log:
>>    s/adress/address/
>
>Do we really need this detail in the log message?  That's what
>diffs are for.

If you are questioning the log message, then the issue is "What
are log messages for?".  The log message is supposed to give a
short but informative summary of what the change is.  These
log messages are informative, and it's hard to imagine how they
could be any shorter.  Sounds like a good log message to me.

I would not want a separate commit for each word that is changed
in a single file, but if there is only one word which needs to
be changed at a given point in time, then what else would you
expect in the log message for that commit?

-- 
Garance Alistair Drosehn            =   gad@eclipse.acs.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message