From owner-freebsd-java@FreeBSD.ORG Wed May 12 06:10:31 2004
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
by hub.freebsd.org (Postfix) with ESMTP id 9A58716A4CE
for <java@hub.freebsd.org>; Wed, 12 May 2004 06:10:31 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
by mx1.FreeBSD.org (Postfix) with ESMTP id DF42243D2D
for <java@hub.freebsd.org>; Wed, 12 May 2004 06:10:30 -0700 (PDT)
(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i4CDAUaj033288
for <java@freefall.freebsd.org>; Wed, 12 May 2004 06:10:30 -0700 (PDT)
(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4CDAUY3033287;
Wed, 12 May 2004 06:10:30 -0700 (PDT)
(envelope-from gnats)
Date: Wed, 12 May 2004 06:10:30 -0700 (PDT)
Message-Id: <200405121310.i4CDAUY3033287@freefall.freebsd.org>
To: java@FreeBSD.org
From: Roman Neuhauser <neuhauser@chello.cz>
Subject: Re: ports/66342: [PATCH] fix ECHO_MSG breakage in java ports
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Roman Neuhauser <neuhauser@chello.cz>
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 May 2004 13:10:31 -0000
The following reply was made to PR ports/66342; it has been noted by GNATS.
From: Roman Neuhauser <neuhauser@chello.cz>
To: freebsd-gnats-submit@FreeBSD.org
Cc:
Subject: Re: ports/66342: [PATCH] fix ECHO_MSG breakage in java ports
Date: Wed, 12 May 2004 15:06:41 +0200
# herve.quiroz@esil.univ-mrs.fr / 2004-05-12 12:33:39 +0200:
> Roman,
>
> I recently tried to find a fix for this problem. I agree IGNORECMD has
> to be changed to something else but with your patch the following page
> still has problem:
>
> http://www.freshports.org/ports-ignore.php
what kind of problem? you don't tell me what I should be looking for.
> This solution (modifying bsd.port.mk) would benefit to other ports, such
> as audio/gnump3d, databases/msql, games/linux-q3ademo...
>
> Attached is a patch I sent to Alexey lately. It's a bit of sed(1) magic
> to justify output. I've got some problem with sed(1) when invoked from
> make(1). That's why there are two lines added in bsd.port.mk:
>
> - The first one is the "correct" regular expression but it doesn't work
> (that's why it is commented).
right. you can't use the "\n" escape in replacement in the s command.
> - The second is some kind of cheat, replacing '\n' by '%' in the regular
> expression, and then filtering through tr(1) to produce 'n'. This is
> quite ugly if you ask me but it works.
it breaks ports whose IGNORE variable contains %.
> --- bsd.port.mk.original Mon Apr 26 16:21:59 2004
> +++ bsd.port.mk Mon Apr 26 16:48:13 2004
> @@ -2577,7 +2577,8 @@
> .if defined(IGNORE_SILENT)
> IGNORECMD= ${DO_NADA}
> .else
> -IGNORECMD= ${ECHO_MSG} "===> ${PKGNAME} ${IGNORE}."
> +#IGNORECMD= ${ECHO_MSG} "===> ${PKGNAME} ${IGNORE}." | ${SED} 's/ */ /g ; s/[^ ]$$/ / ; s/.\{1,80\} /&\n/g'
> +IGNORECMD= ${ECHO_MSG} "===> ${PKGNAME} ${IGNORE}." | ${SED} 's/ */ /g ; s/[^ ]$$/ / ; s/.\{1,80\} /&%/g' | ${TR} "%" "\n"
> .endif
>
> .for target in check-sanity fetch checksum extract patch configure all build install reinstall package
another problem is that the third subst, if it worked, would break
long lines inside words, and would not reflow the text, producing
short line overflows.
moreover, this patch, goes against my recent push to reduce
unnecessary commands in ${PORTSDIR}/Mk/*, so I guess it's not
surprising I'm not terribly excited.
--
FreeBSD 4.9-RELEASE-p2
1:25PM up 1 day, 5:46, 4 users, load averages: 0.00, 0.00, 0.00