From owner-svn-src-head@freebsd.org Tue Sep 22 20:54:27 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EBF7C3F6B65; Tue, 22 Sep 2020 20:54:27 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BwtpW2dXwz4cQg; Tue, 22 Sep 2020 20:54:27 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x32f.google.com with SMTP id k18so4738682wmj.5; Tue, 22 Sep 2020 13:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QWBYGmJZxBqDgB5A9kxRwXgyKh9nLy0O8eD5XcVCE5w=; b=WfHDsPf1rD/ugu+yCC4V2IqEPYlgaGmNMnrc5MbyAvFAZCjXN86StR4a/c6cVMMMR/ gqk0Qm8LqUMHErP27WaZZTkjWxZzugWzP9d9dFA69xxbjFsKl9f1nIcD8/JFapsV9g1O qLX87rvU8V/w0DAtE4UjAe8ZHOjBtUJBjLSVv3dWHWsgLwRe2TyrHyLXsMbELirUUjZV floHP7fs8jl6jIyWnKTmxtUXFpXwc8vAOi4Nd+t9ky5D4ICliywGd3lO053kX58k6Yxv 77jpkPip3WW8X6Xs0OWiD3j05Spc/3RGHY+iRwZOy+RxJVCKsuNjOR/WOxfqx/bqRuxU 43hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QWBYGmJZxBqDgB5A9kxRwXgyKh9nLy0O8eD5XcVCE5w=; b=VSTwsE9RMXyBdA7ytWYoxH6x3uMwexz1wr1TYXfo511s7fVjB+xb8fJu7VfRwmi9TV 5Eb9DukD7c9A1LEpzNq/2Pug1rXGGciPeOdXl4XA/DuDhQCyCPMlT1DY4Gr3qE9Kx/x5 iITto4L3/j12JWOdGgCKdS5CsrGXY3VK7ss6hUs9hZ/vPctSSJv+ccsO3vhncI3DE6iF IyI1Be9AkCntv/ug+xEmXdmNucT7jk+pM6LpzRjHYtOpsQZOwNOWqa1owFcpOiijQxxM 99FWRbHxcNTuiizayCwBo+aIZm/Rbf23SYIU/G1FroPJ8AqfBMJ8DOtC0dACKTqE3sVi iFAg== X-Gm-Message-State: AOAM530sdqKNtbhp5gGWRJwpXuAAYM7/oW7rVtSAk9l2bevH9tB03adr IJKp+HTTIdI1hhhubhOY8t5gypS7v9kxgiu/axmSMKhCpzI= X-Google-Smtp-Source: ABdhPJz2o4Sd414/ozI+DsV2v1wSDcQs2Zn73FomNbS/hbqVGLquapTBBDcdD2+hF/KcSZ2vD3U+w9f0qYaoH+Y+eqI= X-Received: by 2002:a1c:2441:: with SMTP id k62mr2884755wmk.178.1600808064116; Tue, 22 Sep 2020 13:54:24 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6000:187:0:0:0:0 with HTTP; Tue, 22 Sep 2020 13:54:23 -0700 (PDT) In-Reply-To: References: <202009112049.08BKnavL032212@repo.freebsd.org> From: Mateusz Guzik Date: Tue, 22 Sep 2020 22:54:23 +0200 Message-ID: Subject: Re: svn commit: r365643 - head/bin/cp To: Alan Somers Cc: Kyle Evans , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BwtpW2dXwz4cQg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 20:54:28 -0000 Can we instead add a workaround to the build tree? Where is cp /dev/null coming from anyway? Perhaps this can be patched to touch the target file. On 9/22/20, Alan Somers wrote: > On Tue, Sep 22, 2020 at 2:48 PM Kyle Evans wrote: > >> On Fri, Sep 11, 2020 at 3:49 PM Alan Somers wrote: >> > >> > Author: asomers >> > Date: Fri Sep 11 20:49:36 2020 >> > New Revision: 365643 >> > URL: https://svnweb.freebsd.org/changeset/base/365643 >> > >> > Log: >> > cp: fall back to read/write if copy_file_range fails >> > >> > Even though copy_file_range has a file-system agnostic version, it >> still >> > fails on devfs (perhaps because the file descriptor is non-seekable?) >> In >> > that case, fallback to old-fashioned read/write. Fixes >> > "cp /dev/null /tmp/null" >> > >> >> Hi, >> >> Any objection to adding a quick UPDATING entry for this? I'm seeing >> occasional reports of this breakage as recent as today on IRC from >> folks that were a little bit thrown off by this because it throws up >> fairly far into the build and looks like a stand build regression >> instead of a cp regression. >> >> Thanks, >> >> Kyle Evans >> > > No objection. Can you suggest the proper wording? > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > -- Mateusz Guzik