From owner-freebsd-bugs@FreeBSD.ORG Sun Jul 19 09:30:05 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E8311065674 for ; Sun, 19 Jul 2009 09:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 205808FC0C for ; Sun, 19 Jul 2009 09:30:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6J9U4l8055155 for ; Sun, 19 Jul 2009 09:30:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6J9U4PB055154; Sun, 19 Jul 2009 09:30:04 GMT (envelope-from gnats) Resent-Date: Sun, 19 Jul 2009 09:30:04 GMT Resent-Message-Id: <200907190930.n6J9U4PB055154@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Paul Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93A98106566C for ; Sun, 19 Jul 2009 09:26:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 827548FC17 for ; Sun, 19 Jul 2009 09:26:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n6J9Q3Vn004809 for ; Sun, 19 Jul 2009 09:26:03 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n6J9Q33L004808; Sun, 19 Jul 2009 09:26:03 GMT (envelope-from nobody) Message-Id: <200907190926.n6J9Q33L004808@www.freebsd.org> Date: Sun, 19 Jul 2009 09:26:03 GMT From: Paul To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/136895: ndis regression X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2009 09:30:05 -0000 >Number: 136895 >Category: kern >Synopsis: ndis regression >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jul 19 09:30:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Paul >Release: FreeBSD 8.0-BETA2 >Organization: >Environment: FreeBSD 8.0-BETA2 FreeBSD 8.0-BETA2 #5 r195750:195754: Sat Jul 18 17:00:16 UTC 2009 r@root:/usr/obj/usr/src/sys/kernel i386 >Description: regression introduced with r194432 >How-To-Repeat: put ndis0 up before creating vap >Fix: --- /sys/dev/if_ndis/if_ndis.c 2009-06-28 09:15:54.000000000 +0000 +++ if_ndis.c 2009-07-19 09:22:44.000000000 +0000 @@ -2292,6 +2292,8 @@ ifp = sc->ifp; ic = ifp->if_l2com; vap = TAILQ_FIRST(&ic->ic_vaps); + if (vap == NULL) + return; if (!NDIS_INITIALIZED(sc)) { DPRINTF(("%s: NDIS not initialized\n", __func__)); Patch attached with submission follows: --- /sys/dev/if_ndis/if_ndis.c 2009-06-28 09:15:54.000000000 +0000 +++ if_ndis.c 2009-07-19 09:22:44.000000000 +0000 @@ -2292,6 +2292,8 @@ ifp = sc->ifp; ic = ifp->if_l2com; vap = TAILQ_FIRST(&ic->ic_vaps); + if (vap == NULL) + return; if (!NDIS_INITIALIZED(sc)) { DPRINTF(("%s: NDIS not initialized\n", __func__)); >Release-Note: >Audit-Trail: >Unformatted: