From owner-freebsd-current@FreeBSD.ORG Sat Nov 15 17:56:18 2008 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4D3D106567C for ; Sat, 15 Nov 2008 17:56:18 +0000 (UTC) (envelope-from pankov_p@mail.ru) Received: from mx28.mail.ru (mx28.mail.ru [194.67.23.67]) by mx1.freebsd.org (Postfix) with ESMTP id 92C448FC17 for ; Sat, 15 Nov 2008 17:56:18 +0000 (UTC) (envelope-from pankov_p@mail.ru) Received: from mx39.mail.ru (mx39.mail.ru [194.67.23.35]) by mx28.mail.ru (mPOP.Fallback_MX) with ESMTP id A474D798A79 for ; Sat, 15 Nov 2008 19:58:31 +0300 (MSK) Received: from [88.84.200.91] (port=51486 helo=panbook) by mx39.mail.ru with asmtp id 1L1OTa-000PY2-00; Sat, 15 Nov 2008 19:58:26 +0300 X-AntiVirus: Checked by Dr.Web [version: 4.44, engine: 4.44.0.09170, virus records: 457226, updated: 14.11.2008] Message-ID: <491EFFAF.2040700@mail.ru> Date: Sat, 15 Nov 2008 19:58:23 +0300 From: Pankov Pavel Organization: MPEI User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: current@FreeBSD.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam: Not detected X-Mras: OK Cc: Subject: [PATCH] #endif comment fixes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Nov 2008 17:56:18 -0000 Hello. According to style(9), there can be a comment added to #endif, telling the reader about the corresponding #if* condition. This information isn't used by any program; it's just to save some time for humans, reading the code. And, as it isn't checked, these comments have accumulated many errors. Mainly, it's typos, copy-paste bugs, and file rename leftovers. I have prepared a patch to fix some of them in the tree. I clearly understand that the patch cannot be committed as is, because of touched files are maintained outside of FreeBSD source tree. But maybe respective maintainers will be able to review my patch and commit or submit fixes upstream. CVS diff against -CURRENT is available from http://files.pankov.pp.ru/freebsd/endif-comments-fix.diff.bz2 (~ 14 KB). Thank you.