Date: Mon, 13 Dec 2021 21:46:16 +0100 From: Dries Michiels <driesm@freebsd.org> To: Eugene Grosbein <eugen@grosbein.net>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 074939ea0793 - main - security/i2pd: Update to 2.40.0 Message-ID: <d690a20c-685c-775a-2220-6c4a32bc3fb5@freebsd.org> In-Reply-To: <fd37edb8-f819-ddb6-cf33-99ca0cc6a845@grosbein.net> References: <202112131754.1BDHscmg063776@gitrepo.freebsd.org> <fd37edb8-f819-ddb6-cf33-99ca0cc6a845@grosbein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/13/21 20:47, Eugene Grosbein wrote:
> 14.12.2021 0:54, Dries Michiels wrote:
>
>> post-install:
>> ${INSTALL_MAN} ${WRKSRC}/debian/${PORTNAME}.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
>> @${MKDIR} ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d
>> - ${INSTALL_DATA} ${WRKDIR}/i2pd.newsyslog.conf ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d/i2pd.conf
>> + ${INSTALL_DATA} ${WRKDIR}/i2pd.newsyslog.conf ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d/i2pd.conf.sample
> This presents a regression for users upgrading from previous versions that did not change newsyslog.conf.d/i2pd.conf
> and relied on defaults for log rotation. Now they end up without rotation unless catch up with the change, don't they?
That is not true, as the sample is tagged as @sample in pkg-plist.
It will just copy the .sample to the .conf file if you didn't touch it.
If you did, your current config is kept.
> What is a benefit of NOT installing rotation by default?
It is installed, through the @sample macro in pkg-plist.
Dries
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d690a20c-685c-775a-2220-6c4a32bc3fb5>