Date: Tue, 4 Apr 2023 12:23:34 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Alexey Dokuchaev <danfe@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 643336549081 - main - If copy_file_range(2) fails with EXDEV, use fall-back. Message-ID: <CAGudoHEsT5-sDs9M8-w-1sPSSCWGv1Xm5HM8yAtVKFKHr9BFFA@mail.gmail.com> In-Reply-To: <202304041015.334AF7oF006042@critter.freebsd.dk> References: <202304040740.3347eiU8033699@gitrepo.freebsd.org> <ZCvxNeB0A0hDWa8j@FreeBSD.org> <202304040959.3349xqqB005509@critter.freebsd.dk> <ZCv1wFHCOvMEBiJG@FreeBSD.org> <202304041015.334AF7oF006042@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/4/23, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: > -------- > Alexey Dokuchaev writes: > >> Okay, but did it leave an empty file, I wonder? > > I didn't check, but it probably would, because cp(1) must have opened > and created the destination in order to call copy_file_range(2). > > PS: I'll note that EXDEV is not a documented return value from > copy_file_range(2), and my surprise that cp(1) did not revert > to the fall-back, no matter why copy_file_range(2) failed. > that's a new one and should not be happening, something is borked in the kernel -- cross device copies *are* supported i'll look into it later -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHEsT5-sDs9M8-w-1sPSSCWGv1Xm5HM8yAtVKFKHr9BFFA>