From owner-freebsd-testing@FreeBSD.ORG Thu Jan 9 23:42:43 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EE8E5298; Thu, 9 Jan 2014 23:42:43 +0000 (UTC) Received: from mail-pd0-x22c.google.com (mail-pd0-x22c.google.com [IPv6:2607:f8b0:400e:c02::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BDA3D1C7D; Thu, 9 Jan 2014 23:42:43 +0000 (UTC) Received: by mail-pd0-f172.google.com with SMTP id g10so3796954pdj.17 for ; Thu, 09 Jan 2014 15:42:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=8pjffH72MWTJmTfaT5MCPrU2Mpw0U1d/VwiUe0fQXdI=; b=rJn5Ozi2XPKBApDChtWH7ZzxkkPGe4dbx8XSONajA0HWeXuiIQq0FFwY9iso4p5AEJ 4AxuFewIia0zE+0vCd2SOl1OZcXvFUR1f5pPtFvanaZbu3n68YiGhHtIznT/2iUF+pip DgK1wRsdz2qPvtuU0RSq61oPkQHqhmNO7Cj4zW+4fMC4B4JzkprHr57ekBdAxsf6QEC1 45bAlW3LhHYT+Edpj/SRfaVQ4tbHk2RsAUkWam0eCxTI5SdljrBqr8m8SeDkgb3viTGh JcDjInTWTg5cxh9/PSPSlWEUYMhYoTvEBEYY/ymTSlNwbJlx0oioeinISiDonlYGS5xG FJTQ== X-Received: by 10.68.201.226 with SMTP id kd2mr6736764pbc.157.1389310963341; Thu, 09 Jan 2014 15:42:43 -0800 (PST) Received: from [10.0.2.128] ([64.14.143.130]) by mx.google.com with ESMTPSA id i10sm16060808pat.11.2014.01.09.15.42.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 09 Jan 2014 15:42:41 -0800 (PST) References: <20140109233402.GA8193@fbair.virtual.network> Mime-Version: 1.0 (1.0) In-Reply-To: <20140109233402.GA8193@fbair.virtual.network> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <68CF4BF2-E97F-4B5E-920E-854FD6BCA083@gmail.com> X-Mailer: iPhone Mail (11B554a) From: Garrett Cooper Subject: Re: Fixing installation of Kyuafiles Date: Thu, 9 Jan 2014 15:42:39 -0800 To: Julio Merino Cc: "freebsd-testing@freebsd.org" , "sjg@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2014 23:42:44 -0000 > On Jan 9, 2014, at 15:34, Julio Merino wrote: >=20 > Hello, >=20 > The bin/sh and bin/test tests are broken because they cannot be run as roo= t, > yet the testing machines are currently running stuff as root. This is eas= y > to fix by adding a require_user=3D"unprivileged" property to the tests. >=20 > I was going to fix this by adding manually-crafted Kyuafile files that do > the above in bin/sh/tests/ and bin/test/tests/ and setting KYUAFILE=3Dyes i= n > the corresponding Makefile files... but unfortunately that does not work > with NO_CLEAN builds. >=20 > The problem is that bsd.test.mk generates Kyuafile files in the obj direct= ory > and setting KYUAFILE=3Dyes means that make will _still_ see the Kyuafile i= n the > obj directory and not the one that just appeared in src. >=20 > Does the attached patch seem reasonable to prevent this in the future? >=20 > The patch does not fix current build trees with NO_CLEAN, but because > WITH_TESTS is not yet the default I don't think it's a big deal. >=20 > Thank you. > Why not use ${.TARGET} instead of Kyuafile.auto?=