From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 19:30:29 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E9C6F16A408 for ; Mon, 5 Feb 2007 19:30:28 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 78A1813C494 for ; Mon, 5 Feb 2007 19:30:28 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15JUS9V064339 for ; Mon, 5 Feb 2007 19:30:28 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15JUS8O064334; Mon, 5 Feb 2007 19:30:28 GMT (envelope-from gnats) Date: Mon, 5 Feb 2007 19:30:28 GMT Message-Id: <200702051930.l15JUS8O064334@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 19:30:29 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Norikatsu Shigemura Cc: freebsd-rc@FreeBSD.org, freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Mon, 05 Feb 2007 19:20:02 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig10F7C438CF396E3BC8035EEA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Norikatsu Shigemura wrote: > On Sat, 28 Oct 2006 16:10:18 GMT > FreeBSD-gnats-submit@FreeBSD.org wrote: >> Thank you very much for your problem report. >> It has the internal identification `conf/104884'. >> The individual assigned to look at your >> report is: freebsd-bugs.=20 >> You can access the state of your problem report at any time >> via this link: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>> Category: conf >>> Responsible: freebsd-bugs >>> Synopsis: Add support EtherChannel configuration to rc.conf >>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >=20 > I chased HEAD. Please see following patch. > Anyone, please handle this PR? > And I'll make a patch for 6-stable. I just noticed two other things. > +# fec_up ifn ^^^ fec_up uses fec_interfaces, not $1, so this is wrong. > +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC > +# arguments were found and configured; returns 1 otherwise. fec_up is never called with an argument anyway at the moment. It wouldn't be hard to do: work on $1 or $fec_interfaces if $1 is empty. I guess we could use both 'fec_up $ifn' and 'gif_up $ifn' in rc.d/netif. The newly introduced variables also need to be documented in rc.conf.5. Could you please provide a patch for this? I also noticed we don't have gif_down (hence no fec_down). --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig10F7C438CF396E3BC8035EEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx4NqMxEkbVFH3PQRCpa7AJ92OTvKEnTFuvgd8dxE9qMOeslJAgCfS8nk NzppeTdeSYYb8h+DjhsHluc= =GH+e -----END PGP SIGNATURE----- --------------enig10F7C438CF396E3BC8035EEA--