From nobody Fri Jun 21 21:41:49 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W5W5s73Lqz5PMWl for ; Fri, 21 Jun 2024 21:41:53 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-bc0c.mail.infomaniak.ch (smtp-bc0c.mail.infomaniak.ch [45.157.188.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W5W5s3ln0z4cRl for ; Fri, 21 Jun 2024 21:41:52 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-4-0000.mail.infomaniak.ch (smtp-4-0000.mail.infomaniak.ch [10.7.10.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4W5W5p2B8Qz11g2; Fri, 21 Jun 2024 23:41:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1719006110; bh=HF0c1AtpIVkE6TJwNoDVJBT1Dqp8HiYeZVW9leqZitE=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=gLT7tQE4Ijbbga85J/fJAs2rNOBvfXeygc7OOzPu8lbXeHyjhxz7zODrDsgOWKkne T6nsemZf3XKh3vOij4u0mob2audC6BgHma9k7JY/uHfFXrO8VX7fSv1kGYGeYwDsBJ rojpCNMEinlBhBSrmLHDIAiSBa+RTMy0ZGjHD+gXZTsc0xL3PWDJ7gTTz2/5MFD7x6 NcLLU5U/OiOUOG5gnzbyflbPBiQluL/2TRYE8faRT1mhF2AhSDkc8NN92EkDwH7PxG 8upTVGvpKnYMY3D9zR8wxtS9kpmV+wwLyrec9y++336AXbtQqaCHSzTu78hxI/rWsr MLkkgk4KGi+Tw== Received: from unknown by smtp-4-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4W5W5n6PwLz3sZ; Fri, 21 Jun 2024 23:41:49 +0200 (CEST) Message-ID: <805b3975a564733fe080a864a330c1d7@mail.infomaniak.com> Date: Fri, 21 Jun 2024 23:41:49 +0200 Subject: Re: git: 12594e1aee7b - main - math/mathex: new port, C++ library to parse/evaluate mathematical expressions From: Daniel Engberg Reply-To: Daniel Engberg To: Thierry Thomas Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1719006109_11f902dcc062f2b42de0fd33fb8a7349_=_" X-WS-User-Origin: eyJpdiI6ImFYN1d1UkZjZFdlZkxpbkJWYjZqNHc9PSIsInZhbHVlIjoidldDMWI0eDFTbThDQnQ3Z1NpdmR0QT09IiwibWFjIjoiNzJlNTQ0NmJiNzM2ZWQxNTYzYWYwMDA2YWUwMDZiODdiMzk0ZWVhZTFkZGYzZDlmNGExNGRiYWFiY2FjNDA5YSIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6IndkckhOYWo4MWQ4cy9LdDJpTnFYbWc9PSIsInZhbHVlIjoiSy9MTHdxUkRMY3d0U0hSa0dSd1Vudz09IiwibWFjIjoiMWEwMWUzMDJiYjE1MjcyYmIxZWMzYzgwYjJhNDBjYmZmY2QwOTNkYzg4ZWMzOTU3YjVhMDY5Y2QwOTNmNWVjMSIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.703) References: <202406211115.45LBFt3m025401@gitrepo.freebsd.org> <74dfc79ede606f9424af2b0f564b01f3@mail.infomaniak.com> <224470ebe4c1f9da0c394a33cfde261e@mail.infomaniak.com> In-Reply-To: X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:45.157.188.0/22, country:CH] X-Rspamd-Queue-Id: 4W5W5s3ln0z4cRl --_=_swift_1719006109_11f902dcc062f2b42de0fd33fb8a7349_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-06-21T22:05:41.000+02:00, Thierry Thomas wr= ote: >=C2=A0Le=C2=A0ven.=C2=A021=C2=A0juin=C2=A024=C2=A0=C3=A0=C2= =A015:42:24=C2=A0+0200,=C2=A0Daniel=C2=A0Engberg=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C3=A9crivait=C2=A0: >=C2=A0 >>= =C2=A0=C2=A0The=C2=A0only=C2=A0consumer=C2=A0(not=C2=A0linked?)=C2=A0uses= =C2=A0CMake=C2=A0too=C2=A0so=C2=A0I=C2=A0don't=C2=A0see >>=C2=A0=C2=A0tha= t >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0much=C2=A0of=C2=A0a=C2=A0concern?= >=C2=A0 >=C2=A0Maybe,=C2=A0but=C2=A0I=C2=A0prefer=C2=A0the=C2=A0classi= cal=C2=A0way. >=C2=A0 >>=C2=A0=C2=A0Here's=C2=A0a=C2=A0poc=C2=A0with= =C2=A0prefix(ed)=C2=A0examples,matching=C2=A0comment=C2=A0(there=C2=A0a >= >=C2=A0=C2=A0typo) >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0and=C2=A0pkg-desc= r=C2=A0(slightly=C2=A0altered). >=C2=A0 >=C2=A0Thanks,=C2=A0I=E2=80= =99ve=C2=A0just=C2=A0fixed=C2=A0them! There's still a typo in COMMENT,= "C++ library fo" >>=C2=A0=C2=A0Plist=C2=A0is=C2=A0also=C2=A0fixed= =C2=A0when=C2=A0EXAMPLES=C2=A0are=C2=A0disabled=C2=A0(needs=C2=A0to=C2= =A0be >>=C2=A0=C2=A0patched >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0either= =C2=A0way). >=C2=A0 >=C2=A0Do=C2=A0you=C2=A0build=C2=A0it=C2=A0with= =C2=A0some=C2=A0unclean=C2=A0environment? It fails using both ports (1= 4.0, amd64) and Poudriere ... math_mathex_UNSET=3D=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 EXAMPLES ... --> https://pdr2.bofh.network/d= ata/132-diizzy/mathex-no-examples/logs/errors/mathex-0.3.b.log Conside= r using the OPTIONS_SUB helper which makes it much easier https://docs= .freebsd.org/en/books/porters-handbook/book/#options_sub Please also a= t least prefix the binaries (examples) as they have with very generic nam= es both in terms of figuring out what package they belong to and would cl= ash if more ports would use the same approach (see security/mbedtls for e= xample) >=C2=A0Regards. >=C2=A0 >=C2=A0--=C2=A0 >=C2=A0 >= =C2=A0Th.=C2=A0Thomas. Best regards, Daniel --_=_swift_1719006109_11f902dcc062f2b42de0fd33fb8a7349_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-06-21T22:05:41.000+02:00, Thierry Thomas <thier= ry@freebsd.org> wrote:
Le ven. 21 juin 24 =C3=A0 15:42:24 +0200, Daniel Engberg <dan=
iel.engberg.lists@pyret.net>
 =C3=A9crivait :
=


  The only cons=
umer (not linked?) uses CMake too so I don't see that
 much o=
f a concern? 
 
Maybe, but I prefe=
r the classical way.

  Here's a poc with prefix(ed) examples,matching comment (there a =
typo)
 and pkg-descr (slightly altered).
 
Thanks, I=E2=80=99ve just fixed them!
There's still a typo in COMMENT, "C++ library fo"<= br>

<= blockquote class=3D"ws-ng-quote">
<=
br>
  Plist is also fixed when =
EXAMPLES are disabled (needs to be patched
 either way).
<=
/div>
 
Do you build it with some unclean en=
vironment?
It fails using both ports= (14.0, amd64) and Poudriere
...
math_mathex_UN= SET=3D      EXAMPLES
...
--> https://pdr2.bofh.network/data/132-dii= zzy/mathex-no-examples/logs/errors/mathex-0.3.b.log
Consi= der using the OPTIONS_SUB helper which makes it much easier
<= a href=3D"https://docs.freebsd.org/en/books/porters-handbook/book/#options_= sub">https://docs.freebsd.org/en/books/porters-handbook/book/#options_sub

Please also at least prefix the binaries (e= xamples) as they have with very generic names both in terms of figuring out= what package they belong to and would clash if more ports would use the sa= me approach (see security/mbedtls for example)


Regards.
-- 
Th. Thomas.
Best regards,
Daniel
--_=_swift_1719006109_11f902dcc062f2b42de0fd33fb8a7349_=_--