From owner-cvs-all@FreeBSD.ORG Tue Mar 28 09:29:34 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E47C16A429; Tue, 28 Mar 2006 09:29:34 +0000 (UTC) (envelope-from davidxu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FA6A43D5F; Tue, 28 Mar 2006 09:29:30 +0000 (GMT) (envelope-from davidxu@freebsd.org) Received: from [127.0.0.1] (root@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2S9TPw8066547; Tue, 28 Mar 2006 09:29:27 GMT (envelope-from davidxu@freebsd.org) Message-ID: <442901FC.6010008@freebsd.org> Date: Tue, 28 Mar 2006 17:29:32 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060302 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Dag-Erling Smorgrav References: <200603280918.k2S9IZM5008601@repoman.freebsd.org> In-Reply-To: <200603280918.k2S9IZM5008601@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern syscalls.master src/sys/sys sysproto.h umtx.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 09:29:34 -0000 Dag-Erling Smorgrav wrote: > des 2006-03-28 09:18:34 UTC > > FreeBSD src repository > > Modified files: > sys/kern syscalls.master > sys/sys sysproto.h umtx.h > Log: > The undocumented and deprecated system call _umtx_op() takes two pointer > arguments. The first one is never used (all callers pass in 0); the > second is sometimes used to pass in a struct timespec * which is used as > a timeout and never modified. Constify that argument so callers can pass > a const struct timespec * without jumping through hoops. > > Revision Changes Path > 1.214 +1 -1 src/sys/kern/syscalls.master > 1.193 +1 -1 src/sys/sys/sysproto.h > 1.18 +3 -3 src/sys/sys/umtx.h > > This is an incorrect change, please backout it. the _umtx_op parameters never should only accept const void *, in fact, the interface was designed to extendable for future use. you can use __DECONST macro in umtx.h to disable compiler warnings, breaking it could cause FreeBSD to not have optimized thread library can be used.next when you want to change umtx code, please discuss with me first. Regards, David Xu