From owner-freebsd-bugs@freebsd.org Mon Aug 27 13:58:06 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 254DF108AC09 for ; Mon, 27 Aug 2018 13:58:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B58F6716D8 for ; Mon, 27 Aug 2018 13:58:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 7B18A108AC07; Mon, 27 Aug 2018 13:58:05 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69B67108AC06 for ; Mon, 27 Aug 2018 13:58:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0AECD716D7 for ; Mon, 27 Aug 2018 13:58:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 402D815187 for ; Mon, 27 Aug 2018 13:58:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w7RDw4eO055102 for ; Mon, 27 Aug 2018 13:58:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w7RDw4wK055099 for bugs@FreeBSD.org; Mon, 27 Aug 2018 13:58:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 230937] nfsuserd - missing endpwent() and endgrent() before daemon() & fork() Date: Mon, 27 Aug 2018 13:58:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: peter@ifm.liu.se X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2018 13:58:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230937 Bug ID: 230937 Summary: nfsuserd - missing endpwent() and endgrent() before daemon() & fork() Product: Base System Version: 11.2-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: peter@ifm.liu.se Created attachment 196598 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D196598&action= =3Dedit Patch to /usr/src/usr.sbin/nfsuserd/nfsuserd.c We are using a (own developed) DB based backend for nsswitch in order to improve speed for our file servers. After upgrading to 11.2 we noticed that= we had problems on one of them in that initially on a newly booted server NFS clients correctly saw user & group names but then after a short while the client started reporting "nobody" instead. Investigating this issue it seemed to be connected to the cache timeout as specified for the nfsuserd daemon (we used 10 minutes). Any uid -> name or = gid -> name lookups after the timeout limit would just return "nobody". Looking at the source code for nfsuserd.c I noticed missing endpwent() and endgrent() calls during the initial cache priming of users & groups and bef= ore the slave workers processes were forked off, and adding those made this work nicely again.=20 Please find enclosed a (very) simple patch that adds those missing calls. --=20 You are receiving this mail because: You are the assignee for the bug.=