From owner-svn-src-head@FreeBSD.ORG Wed Jun 26 07:27:02 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E1BEBBBA for ; Wed, 26 Jun 2013 07:27:02 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 5911412C7 for ; Wed, 26 Jun 2013 07:27:01 +0000 (UTC) Received: (qmail 43253 invoked from network); 26 Jun 2013 08:20:21 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 26 Jun 2013 08:20:21 -0000 Message-ID: <51CA97AE.4090306@freebsd.org> Date: Wed, 26 Jun 2013 09:26:38 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: John Baldwin Subject: Re: svn commit: r252209 - in head: share/man/man9 sys/kern sys/sys References: <201306251844.r5PIiFDZ009708@svn.freebsd.org> In-Reply-To: <201306251844.r5PIiFDZ009708@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jun 2013 07:27:02 -0000 On 25.06.2013 20:44, John Baldwin wrote: > Author: jhb > Date: Tue Jun 25 18:44:15 2013 > New Revision: 252209 > URL: http://svnweb.freebsd.org/changeset/base/252209 > > Log: > Several improvements to rmlock(9). Many of these are based on patches > provided by Isilon. > - Add an rm_assert() supporting various lock assertions similar to other > locking primitives. Because rmlocks track readers the assertions are > always fully accurate unlike rw_assert() and sx_assert(). > - Flesh out the lock class methods for rmlocks to support sleeping via > condvars and rm_sleep() (but only while holding write locks), rmlock > details in 'show lock' in DDB, and the lc_owner method used by > dtrace. > - Add an internal destroyed cookie so that API functions can assert > that an rmlock is not destroyed. > - Make use of rm_assert() to add various assertions to the API (e.g. > to assert locks are held when an unlock routine is called). > - Give RM_SLEEPABLE locks their own lock class and always use the > rmlock's own lock_object with WITNESS. > - Use THREAD_NO_SLEEPING() / THREAD_SLEEPING_OK() to disallow sleeping > while holding a read lock on an rmlock. Thanks! Would it make sense to move struct rm_queue from struct pcpu itself to using DPCPU as a next step? > Submitted by: andre Actually these were only relayed by me and came from Max Laier / Stephan Uphoff. So all fame to them. > Obtained from: EMC/Isilon -- Andre