From owner-freebsd-hackers@freebsd.org Tue Nov 3 10:17:58 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BF261453FCC for ; Tue, 3 Nov 2020 10:17:58 +0000 (UTC) (envelope-from xtouqh@hotmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CQQhk2vZnz4vfd for ; Tue, 3 Nov 2020 10:17:58 +0000 (UTC) (envelope-from xtouqh@hotmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 63A03453EED; Tue, 3 Nov 2020 10:17:58 +0000 (UTC) Delivered-To: hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 63635453FCB for ; Tue, 3 Nov 2020 10:17:58 +0000 (UTC) (envelope-from xtouqh@hotmail.com) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn0817.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::817]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CQQhh2WrZz4vPQ for ; Tue, 3 Nov 2020 10:17:55 +0000 (UTC) (envelope-from xtouqh@hotmail.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F65JvpUFnDVca8kZx0eORTj4jt60YVPTceGU6ScPtLpjSki6I2RMDhR6fH4JzqJ5LyTGlc3tp5xWxFMu5DZeuKnYvtb/ekzHXRJh7vc0Kdy68zgm5/XjhtUNwcRJoVi8guih+M6u98BSOS3weqMmEm0ZlRrU7h3YC9MWy1SAYzTMIDrnCw1jy1ta3GQBwBHobJycabmcZIelFwV671Ii8lQeTN4yQnt+/gy+axECB9EznnV31W5PKx1/Rbvya+vevb5ygm8NAYhuqdXM20FmaDFIQYndU2L0PwhYxpnYm/jTP5fBkEKhNeXoLcrGwDSTjiC/1icC/Pxhnqp86YMz7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=czBAACCZXurUSrERRW2xXAzQOyVeGqyCLDypITlh2nA=; b=kuTo29m6r3wz9ovj2vs7JZDpQmxeLTUUSAGFo+cLwtqUB8D5X5V38s5ErNlCl1ftec7aOrUbAlNCSdiQP//D9Ic0+9zirWGQF1L6a9j2dXzCL9TlhGK5hSG4l1ppyJNkeauLSY2ofWSnIHM0mSQFaljbjVRbm/ETUCzzhj8lpNy6N1JNM9Y8JSZvQLost540dSLSdWTvzApEZn74YEuCAOzrE5wrmkUMBopir8k1gn4OPaR0/qLFX2P88Vy+5bEuaw8Adsrt6FwW/VQKqPdBE2jAV+5zRwJh61KtM7JBi2TNrJ+CjGSgKR+L+fKXuzm47u3/UrX+RvAqvnzJCp0NOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=czBAACCZXurUSrERRW2xXAzQOyVeGqyCLDypITlh2nA=; b=GyER9gyZ93QGd/e88Zrq2UrPdlFuDcMbjdrJaUDof24mk9zWR2CCRZ9/qi+ID2olvVJqNYcvCSidVTECqFIcLsyjCbMahERj0csfGkfFdVKZGgtbnsV0f0+pQEJXntk9p8QDZ0iXtaE5pzhmgobk0KRZ7ntLoaLrqIuyo1hpm0UC9NfCrzmaGHTnsp1lPt9XYp0O8K0toqsk+Nh286/kkrSbMRDyI2X1jNR1GTWOpOqh+xgaHi3cspzVw+T0/7kIoavbR6MYfAdkQl0/TBJ8QOVwe2M8m1TvUUJU6QhGqvrxm/WGF4H4rhThOGHj3f0DJ0T2xKDuB/qNcyB+HjBFYg== Received: from DB3EUR04FT010.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0c::49) by DB3EUR04HT048.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0c::322) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15; Tue, 3 Nov 2020 10:17:52 +0000 Received: from AM0PR06MB3986.eurprd06.prod.outlook.com (2a01:111:e400:7e0c::4e) by DB3EUR04FT010.mail.protection.outlook.com (2a01:111:e400:7e0c::146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Tue, 3 Nov 2020 10:17:52 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:7F07B32EDA43AEC9E269B8923E0C6392087986DF1014BCA24434E99990E66DEE; UpperCasedChecksum:5523C737B84A02E2EF5DD94BA62C83EBD94E02AF8117186E3CDB8FBB3C7AF369; SizeAsReceived:8857; Count:47 Received: from AM0PR06MB3986.eurprd06.prod.outlook.com ([fe80::759a:af46:6f2:8fb8]) by AM0PR06MB3986.eurprd06.prod.outlook.com ([fe80::759a:af46:6f2:8fb8%7]) with mapi id 15.20.3499.032; Tue, 3 Nov 2020 10:17:52 +0000 Subject: Re: KASSERT(val != 0) not triggering in linux_errno.c reading outside of array To: Hans Petter Selasky , hackers@freebsd.org References: <77d2eef0-9cc8-aa39-6d28-a7fb41e233ac@selasky.org> From: xtouqh@hotmail.com Message-ID: Date: Tue, 3 Nov 2020 13:17:51 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TMN: [YFBkGaOo6Wgap/Sti3zNHp5lgu07j0m5] X-ClientProxiedBy: FR2P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::19) To AM0PR06MB3986.eurprd06.prod.outlook.com (2603:10a6:208:b6::28) X-Microsoft-Original-Message-ID: <07e18962-5e69-b3cc-f3d0-dd388ff3f500@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.6] (91.240.124.157) by FR2P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.10 via Frontend Transport; Tue, 3 Nov 2020 10:17:52 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: b70c7a47-e82f-45f4-0130-08d87fe1b92f X-MS-TrafficTypeDiagnostic: DB3EUR04HT048: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ULSifWbJuK/KgybtFrQRxG/jvCrsu2WaXgOoYaEmGnu6zP1CMvbunXLy55qWP6ku+mMkUo5eID1GI6Kek9wqK9Bl1cSQdoa5UPAQ4vXkFkT1yYFGtnHLZNGKMu9/hstRIdeooOcpPKx+NqZ7w1TxCUPyVIVuUT25Z0lAb8zt+1I1famp8yLGWjqFLM9MXlsa2yeyVs8j3W2q68/yp9ZrbA== X-MS-Exchange-AntiSpam-MessageData: 3SqQtivVURjWz59BfgkAgYLdZLzt3xl6XnRa+rF0kk0r/vGs+qU6o0NAcX+0EwnG+TlH3AWUF7EGC4N8FbXsNhXrdfQXhg3mDUgAQZ1Zt7dH/K5MFi8n3AhNYfPdkpHtCMt0qrFnCUH/qVJo/or3pQ== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: b70c7a47-e82f-45f4-0130-08d87fe1b92f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 10:17:52.6388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DB3EUR04FT010.eop-eur04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3EUR04HT048 X-Rspamd-Queue-Id: 4CQQhh2WrZz4vPQ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hotmail.com header.s=selector1 header.b=GyER9gyZ; dmarc=pass (policy=none) header.from=hotmail.com; spf=pass (mx1.freebsd.org: domain of xtouqh@hotmail.com designates 2a01:111:f400:fe0c::817 as permitted sender) smtp.mailfrom=xtouqh@hotmail.com X-Spamd-Result: default: False [-2.88 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.03)[-1.035]; R_DKIM_ALLOW(-0.20)[hotmail.com:s=selector1]; RCVD_COUNT_FIVE(0.00)[5]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[hotmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a01:111:f400::/48]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.03)[-1.031]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[hotmail.com:+]; SUBJECT_HAS_EXCLAIM(0.00)[]; FROM_NO_DN(0.00)[]; NEURAL_HAM_SHORT(-1.32)[-1.317]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[hotmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[hotmail.com]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; FORGED_MUA_THUNDERBIRD_MSGID_UNKNOWN(2.50)[]; MAILMAN_DEST(0.00)[hackers]; DWL_DNSWL_NONE(0.00)[hotmail.com:dkim] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 10:17:58 -0000 Hans Petter Selasky wrote: > Hi, > > Should: > >         for (i = 1; i < sizeof(linux_errtbl); i++) { > > Be: > >         for (i = 1; i < sizeof(linux_errtbl)/sizeof(linux_errtbl[0]); > i++) { > > > Or: > >         for (i = 1; i < (int)nitems(linux_errtbl); i++) { That's right, and I added the same comment in the review. My question is different though -- with the issue present, KASSERT() should have triggered (there are 0 values with incorrect indexes, added printf() confirms that) exposing the bug, but it does not -- WHY? -- I just want to understand what's going on.