From owner-svn-src-head@freebsd.org Tue Nov 17 23:28:18 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 95E7C471D7A for ; Tue, 17 Nov 2020 23:28:18 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound5a.ore.mailhop.org (outbound5a.ore.mailhop.org [44.233.67.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CbMZB2Bcgz3sbY for ; Tue, 17 Nov 2020 23:28:18 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1605655696; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=nMhsc+azZGKbcT1E4wYYhz2XN7jVcZcF9ZM8SYyOANgX29wpkCRflBcC+T6aH8lmnWU0wM3XsxMgG 8qRu6T9DfCWmXLYfhDS7fQZAZhqFncxdudFT3/uGwbOm8hQ6/jBJsdjnjtrDcRMJpn5elCR7F1DoNa Ml/E1oIkJ011KgT87QSUHB4eBOMHbGG/TUVWhzEUlz9BMpq0tAx6vkbiQ/cs08lm81tP21cQLZCYxl YbsKN5DP4rlcRezoacBzTMPHPDpb7oX7WXWbbITxZxlpYIBgQ78w4KwejWfLFIUZhgKej4pkDKP1gk p6Nv94VghH9PZjI5aVPFEfcfh93KzYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=dBzJrZjg3SMon2nExhWYI/3FnlX+p3cXDmrPLkCA9Fg=; b=s4e1JD9W8/BVOOWpE/i9JiUIMl/H8nMfR6Q8DnAH67PF3Hf1SZfI87mfi3RpdBLDgv8tAariD7Zhj o+UvY0F45lCEzIiDjkd0ezptuwQXziKED0mCO3DSM2FemODGlGoU3E0lKi1hHK0jpW9UmSwdAJQm32 wNL0d9v7F4Ctgsjoo23w1L1a8mMBu8L/X/X1tYSM7PkpfDqQq4KjF6fj+hNYz4oGktKK+rHSllllEk /QBDT3xEht4lGHgLlFe5R3ES8He8hbWOmIoJqhiIUGFBkLwhInkHetsKwT1G4KucnXZSLMlnc3Y12E DxuRxnY8xBp1Lpj4hXMahJEyp+knyNw== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=dBzJrZjg3SMon2nExhWYI/3FnlX+p3cXDmrPLkCA9Fg=; b=gcfS43/+fC7uu6QKNeomvzynzfk1Am5Kb0+4Ont4jbdqWItuFEpKxE90kPZWgCq2jJo9iLbMdtM5H eUiUHkat0E1aXwmsmOPg3YtijegGJrLx2fS7BDy+QA7Myc6xVRt7vliz+eu8jhumeR49fXNDU0NgG2 rhOHychNT+0dysXuO4XRz3rpTxKsSISociQUIYKU71r7tqRRf00qEO6EkhZZdHTCsbO3vSouQZOZtj qXgPGOnvqAE0tSxBGDQRCrY3xY6KbtaaM1kKlZxtCMMcXbAWwicquuYV6uOCvDlgp4n7SV68cKMF4Q SlNJmgkaiNgYcXE0gkyyxHuR3I1wdeQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 90404e9e-292c-11eb-8b38-614106969e8d X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 90404e9e-292c-11eb-8b38-614106969e8d; Tue, 17 Nov 2020 23:28:15 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 0AHNSDUl043174; Tue, 17 Nov 2020 16:28:13 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <41b3e36ec703b2f12632e9e194f132e64b3910a9.camel@freebsd.org> Subject: Re: svn commit: r367678 - head/usr.sbin/freebsd-update From: Ian Lepore To: rgrimes@freebsd.org Cc: src-committers , svn-src-all , svn-src-head Date: Tue, 17 Nov 2020 16:28:13 -0700 In-Reply-To: <202011172241.0AHMffWK086732@gndrsh.dnsmgr.net> References: <202011172241.0AHMffWK086732@gndrsh.dnsmgr.net> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CbMZB2Bcgz3sbY X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 23:28:18 -0000 On Tue, 2020-11-17 at 14:41 -0800, Rodney W. Grimes wrote: > > On Sat, Nov 14, 2020 at 11:20 AM Mateusz Piotrowski < > > 0mp@freebsd.org> wrote: > > > > > > Hello Rodney, > > > > > > On 11/14/20 4:59 PM, Rodney W. Grimes wrote: > > > > > Author: 0mp (doc,ports committer) > > > > > Date: Sat Nov 14 13:07:41 2020 > > > > > New Revision: 367678 > > > > > URL: https://svnweb.freebsd.org/changeset/base/367678 > > > > > > > > > > Log: > > > > > Document the PAGER environment variable > > > > > > > > > > Sometimes users want to use freebsd-update(8) in a non- > > > > > interactive way and > > > > > what they often miss is that they have to set PAGER to > > > > > cat(1) in order to > > > > > avoid interactive prompts from less(1). > > > > > > > > Which was caused by the change of invoking more(1) as less(1) > > > > causing > > > > this regression, as when invoked as more(1) it falls off the > > > > end of > > > > empty input and causes no such interactive prompt. > > > > > > > > Setting PAGER to more(1) also fixes this. > > > > > > Mmm, I'm not sure if that would work. If I run "jot 1000 | more" > > > in my terminal I still get an > > > interactive prompt. Could it be that you are referring to a > > > different more(1) implementation? I'm > > > clearly missing something. > > > > > Part of what your missing is freebsd-update(8) often outputs a 0 > length file which less(1) well want you to respond Quit to before > going to the next file. more(1) does not do that. > > jot 1000 produces 1 x 1000 line file, that is not whats causing > the issues with freebsd-update and less(1), it is more like > 1000 x 1 line files. > > > > > more(1) is more or less like `less -E`, which is a default PAGER I > > had > > advocated for back when it changed. It can be mostly non- > > interactive > > as long as your diffs are small, but it's definitely much less > > painful. > > Yes, that would of been less painful, note that iirc there are a > few other places effected in similiar ways with 0 line output > files sent to less(1) that cause a need to hit a bunch of q's > to get the command completed. > > Since I am an aged more(1) user I just globally fix PAGER. > It would of been far less painful had PAGER simply been > changed to less rather than all the binary invokations > beeing changed, but hind sight is amazing. > You might find some solace in the brave new world by adding to your .cshrc: setenv LESS -m -E -- Ian