From owner-freebsd-arch@FreeBSD.ORG  Tue Nov 22 19:24:33 2011
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6B9081065677;
	Tue, 22 Nov 2011 19:24:33 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 411508FC1C;
	Tue, 22 Nov 2011 19:24:33 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id E977E46B3C;
	Tue, 22 Nov 2011 14:24:32 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5AF3CB93F;
	Tue, 22 Nov 2011 14:24:32 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Robert Millan <rmh@debian.org>
Date: Tue, 22 Nov 2011 14:21:53 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p8; KDE/4.5.5; amd64; ; )
References: <CAOfDtXPX1Rv9T7+1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com>
	<201111220824.07823.jhb@freebsd.org>
	<CAOfDtXP=nBd-PgXK0cK-SkRzFO914ryme64n8Wfix8rdX=NNmg@mail.gmail.com>
In-Reply-To: <CAOfDtXP=nBd-PgXK0cK-SkRzFO914ryme64n8Wfix8rdX=NNmg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201111221421.53395.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Tue, 22 Nov 2011 14:24:32 -0500 (EST)
Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>,
	freebsd-current@freebsd.org, freebsd-arch@freebsd.org
Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Nov 2011 19:24:33 -0000

On Tuesday, November 22, 2011 12:59:19 pm Robert Millan wrote:
> 2011/11/22 John Baldwin <jhb@freebsd.org>:
> > Is __FreeBSD_version defined if __FreeBSD_kernel__ is defined on kFreeBSD?
> 
> Not currently (except for kernel-space code), but if all the checks
> that use __FreeBSD_version are like the one you describe, I think it'd
> make sense.

I can think of cases where you might want it exposed (e.g. in the parts
of net-snmp that grovel around in kernel data structures and use
__FreeBSD_version to figure out what the right thing to do is, possibly
the same with lsof).  

> But we need to make sure that defining it wouldn't suddenly enable
> code that is intended for FreeBSD userland, like it happens with
> __FreeBSD__.

Correct.  I don't believe that is the case since normally one has to
check for __FreeBSD__ before using __FreeBSD_version.

-- 
John Baldwin