From owner-freebsd-hackers@FreeBSD.ORG Mon Nov 1 15:20:03 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1646C1065672 for ; Mon, 1 Nov 2010 15:20:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D10E78FC1F for ; Mon, 1 Nov 2010 15:20:02 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 53F6246B82; Mon, 1 Nov 2010 11:20:02 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6B7CE8A009; Mon, 1 Nov 2010 11:20:01 -0400 (EDT) From: John Baldwin To: freebsd-hackers@freebsd.org Date: Mon, 1 Nov 2010 09:28:12 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <4CCB62D6.1050808@bluezbox.com> In-Reply-To: <4CCB62D6.1050808@bluezbox.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011010928.12562.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Mon, 01 Nov 2010 11:20:01 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: Oleksandr Tymoshenko Subject: Re: [PATCH] hwpmc(4) syscall arguments fix X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2010 15:20:03 -0000 On Friday, October 29, 2010 8:12:06 pm Oleksandr Tymoshenko wrote: > I ran into problems trying to get hwpmc to work on 64-bit MIPS > system with big endian byte order. Turned out hwpmc syscall handler > is byte-order and register_t size agnostic unlike the rest of syscalls. > The best solution I have so far is a copy sys/sysproto.h approach: > http://people.freebsd.org/~gonzo/patches/hwpmc-syscall.diff > > Any other ideas how to get it fixed in more clean way? Yes, a better way would be to add pmc_syscall() to sys/kern/syscalls.master as a NOSTD system call. Then it's arguments would be included in sysproto.h directly. -- John Baldwin