From owner-freebsd-transport@freebsd.org Sun Apr 18 17:27:48 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7722B5EF962 for ; Sun, 18 Apr 2021 17:27:48 +0000 (UTC) (envelope-from pho@holm.cc) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNcN4117Pz3s5l for ; Sun, 18 Apr 2021 17:27:48 +0000 (UTC) (envelope-from pho@holm.cc) Received: by mailman.nyi.freebsd.org (Postfix) id 228325EFD8F; Sun, 18 Apr 2021 17:27:48 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 224815EFBC0 for ; Sun, 18 Apr 2021 17:27:48 +0000 (UTC) (envelope-from pho@holm.cc) Received: from relay05.pair.com (relay05.pair.com [216.92.24.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNcN409b3z3sHN for ; Sun, 18 Apr 2021 17:27:47 +0000 (UTC) (envelope-from pho@holm.cc) Received: from x8.osted.lan (unknown [80.208.71.94]) by relay05.pair.com (Postfix) with ESMTP id 60A641A291D; Sun, 18 Apr 2021 13:27:46 -0400 (EDT) Received: from x8.osted.lan (localhost [127.0.0.1]) by x8.osted.lan (8.15.2/8.15.2) with ESMTPS id 13IHRj35056777 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 18 Apr 2021 19:27:46 +0200 (CEST) (envelope-from pho@x8.osted.lan) Received: (from pho@localhost) by x8.osted.lan (8.15.2/8.15.2/Submit) id 13IHRjkQ056776; Sun, 18 Apr 2021 19:27:45 +0200 (CEST) (envelope-from pho) Date: Sun, 18 Apr 2021 19:27:45 +0200 From: Peter Holm To: "Scheffenegger, Richard" Cc: "transport@freebsd.org" Subject: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Message-ID: <20210418172745.GA56730@x8.osted.lan> References: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> <20210418060040.GA48834@x8.osted.lan> <20210418090419.GA51040@x8.osted.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4FNcN409b3z3sHN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 17:27:48 -0000 On Sun, Apr 18, 2021 at 02:54:38PM +0000, Scheffenegger, Richard wrote: > It appears that the SACK scoreboard ended up unordered (the assumption/invariant is for it to remain sorted for efficient processing): > > tp->snd_holes > 0xfffff80726393c00 3958849524 3958865856 > 0xfffff80726393bc0 3958816860 3958849524 > 0xfffff80726393ae0 3959110836 3959192496 > > The 2nd entry has lower sequence numbers than the first. The KASSERT happened, when this hole was scheduled for retransmission, but snd_una already acknowledged it by that time... > > It seems the reproduction is stable, I will look into where this happens... > OK. Let me know if there is anything I can help with. - Peter > Richard Scheffenegger > > > -----Ursprüngliche Nachricht----- > Von: owner-src-committers@freebsd.org Im Auftrag von Peter Holm > Gesendet: Sonntag, 18. April 2021 11:04 > An: Scheffenegger, Richard > Cc: Richard Scheffenegger ; src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev-commits-src-main@freebsd.org; transport@freebsd.org > Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > > On Sun, Apr 18, 2021 at 08:30:20AM +0000, Scheffenegger, Richard wrote: > > Hi Peter, > > > > Hmm... the panic appears to be due to a stale entry in the sack scoreboard - a hole not having been closed up to snd_una... > > > > Unlikely that this was solely due to this change by itself. > > > > Can I get the vmcore and kernel.debug for a close investigation? > > > > Sure. Uploaded to: https://people.freebsd.org/~pho/kernel.vmcore.320-mercat1.tar > > - Peter > > > > > Richard Scheffenegger > > > > -----Ursprüngliche Nachricht----- > > Von: Peter Holm > > Gesendet: Sonntag, 18. April 2021 08:01 > > An: Richard Scheffenegger > > Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; > > dev-commits-src-main@freebsd.org > > Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to > > sack.revised, and enable by default > > > > NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > > > > > > > On Sat, Apr 17, 2021 at 01:50:25PM +0000, Richard Scheffenegger wrote: > > > The branch main has been updated by rscheff: > > > > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=d1de2b05a001d3d80f633f576f49 > > > 09 > > > c2686dda3d > > > > > > commit d1de2b05a001d3d80f633f576f4909c2686dda3d > > > Author: Richard Scheffenegger > > > AuthorDate: 2021-04-17 12:59:30 +0000 > > > Commit: Richard Scheffenegger > > > CommitDate: 2021-04-17 12:59:45 +0000 > > > > > > tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > > > > > As full support of RFC6675 is in place, deprecating > > > net.inet.tcp.rfc6675_pipe and enabling by default > > > net.inet.tcp.sack.revised. > > > > > > Reviewed By: #transport, kbowling, rrs > > > Sponsored by: NetApp, Inc. > > > Differential Revision: https://reviews.freebsd.org/D28702 > > > --- > > > share/man/man4/tcp.4 | 25 ++++++++++++++----------- > > > sys/netinet/cc/cc_cubic.c | 2 +- > > > sys/netinet/cc/cc_htcp.c | 2 +- > > > sys/netinet/cc/cc_newreno.c | 2 +- > > > sys/netinet/tcp_input.c | 11 +++-------- > > > sys/netinet/tcp_sack.c | 12 +++++++++--- > > > sys/netinet/tcp_var.h | 4 ++-- > > > 7 files changed, 31 insertions(+), 27 deletions(-) > > > > > > diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 index > > > d01505e58427..cbb8021226fe 100644 > > > --- a/share/man/man4/tcp.4 > > > > Could this panic be related? > > > > 20210418 07:19:59 all (204/751): jumbo.sh > > panic: tcp_output: sack block to the left of una : -293976 cpuid = 3 > > time = 1618723234 > > KDB: stack backtrace: > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > > 0xfffffe00e49b0550 > > vpanic() at vpanic+0x181/frame 0xfffffe00e49b05a0 > > panic() at panic+0x43/frame 0xfffffe00e49b0600 > > tcp_output() at tcp_output+0x27dc/frame 0xfffffe00e49b07c0 > > tcp_do_segment() at tcp_do_segment+0x32a3/frame 0xfffffe00e49b08b0 > > tcp_input() at tcp_input+0xbd5/frame 0xfffffe00e49b0a10 > > ip_input() at ip_input+0x194/frame 0xfffffe00e49b0aa0 > > swi_net() at swi_net+0x1a1/frame 0xfffffe00e49b0b20 > > ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e49b0bb0 > > fork_exit() at fork_exit+0x80/frame 0xfffffe00e49b0bf0 > > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e49b0bf0 > > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > > > > https://people.freebsd.org/~pho/stress/log/log0094.txt > > > > - Peter