From owner-freebsd-fs@FreeBSD.ORG  Mon Oct  4 12:42:54 2004
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5012716A4CE; Mon,  4 Oct 2004 12:42:54 +0000 (GMT)
Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EF2F243D41; Mon,  4 Oct 2004 12:42:53 +0000 (GMT)
	(envelope-from danfe@regency.nsu.ru)
Received: from regency.nsu.ru ([193.124.210.26])
	by mx.nsu.ru with esmtp (Exim 4.34)
	id 1CESBZ-0005nd-FI; Mon, 04 Oct 2004 19:43:25 +0700
Received: from regency.nsu.ru (localhost [127.0.0.1])
	by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i94CgcZN025151;
	Mon, 4 Oct 2004 19:42:38 +0700 (NOVST)
	(envelope-from danfe@regency.nsu.ru)
Received: (from danfe@localhost)
	by regency.nsu.ru (8.12.10/8.12.10/Submit) id i94Cgcn6025112;
	Mon, 4 Oct 2004 19:42:38 +0700 (NOVST)
	(envelope-from danfe)
Date: Mon, 4 Oct 2004 19:42:38 +0700
From: Alexey Dokuchaev <danfe@nsu.ru>
To: Takanori Watanabe <takawata@init-main.com>
Message-ID: <20041004124238.GB22153@regency.nsu.ru>
References: <4160FBD9.10603@geminix.org>
	<200410040912.i949CEjk012965@sana.init-main.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200410040912.i949CEjk012965@sana.init-main.com>
User-Agent: Mutt/1.4.2.1i
cc: freebsd-fs@freebsd.org
cc: Boris Popov <bp@freebsd.org>
cc: das@freebsd.org
cc: freebsd-current@freebsd.org
cc: Uwe Doering <gemini@geminix.org>
Subject: Re: Your CVS fix 1.109 to union_vnops.c
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Oct 2004 12:42:54 -0000

Hmm.  Looks like there's style(9) typo here:

> +	if(error)
	 ^^ missing space

> +		goto bad;
> +	um->um_upperdev = va.va_fsid;

And here:

> +	if(vap->va_fsid == um->um_upperdev)
	 ^^ missing space
> +		vap->va_fsid = ap->a_vp->v_mount->mnt_stat.f_fsid.val[0];

./danfe