From owner-freebsd-audit@FreeBSD.ORG  Mon Oct  6 17:24:35 2003
Return-Path: <owner-freebsd-audit@FreeBSD.ORG>
Delivered-To: freebsd-audit@freebsd.org
Received: from green.bikeshed.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1B0B716A4B3; Mon,  6 Oct 2003 17:24:35 -0700 (PDT)
Received: from green.bikeshed.org (localhost [127.0.0.1])
	by green.bikeshed.org (8.12.10/8.12.9) with ESMTP id h970OYcR011888;
	Mon, 6 Oct 2003 20:24:34 -0400 (EDT)
	(envelope-from green@green.bikeshed.org)
Received: from localhost (green@localhost)h970OWPI011885;
	Mon, 6 Oct 2003 20:24:33 -0400 (EDT)
Message-Id: <200310070024.h970OWPI011885@green.bikeshed.org>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Hiroki Sato <hrs@eos.ocn.ne.jp>
In-Reply-To: Message from Hiroki Sato <hrs@eos.ocn.ne.jp> 
	<20030920.115238.96090140.hrs@eos.ocn.ne.jp> 
From: "Brian F. Feldman" <green@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 06 Oct 2003 20:24:32 -0400
Sender: green@green.bikeshed.org
cc: audit@freebsd.org
Subject: Re: bin/56502 
X-BeenThere: freebsd-audit@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD Security Audit <freebsd-audit.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-audit>,
	<mailto:freebsd-audit-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-audit>
List-Post: <mailto:freebsd-audit@freebsd.org>
List-Help: <mailto:freebsd-audit-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-audit>,
	<mailto:freebsd-audit-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Oct 2003 00:24:35 -0000

I don't see any errors; there is a part that seems unnecessary, and a couple 
places that have/don't have spaces where they would be preferred (so these 
are just style issues anyway, not very important):
    -           state[-1] = MAX_TYPES * (rptr - state) + rand_type;
    +           state[-1] = MAX_TYPES * (uint32_t)(rptr - state) + rand_type;
I believe that you don't need to cast in that situation, that you will get a 
compatible size_t or something close to that.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\