From owner-svn-src-head@FreeBSD.ORG  Sat Dec 18 18:41:14 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F1160106564A;
	Sat, 18 Dec 2010 18:41:14 +0000 (UTC)
	(envelope-from onemda@gmail.com)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com
	[209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 2C45F8FC0A;
	Sat, 18 Dec 2010 18:41:14 +0000 (UTC)
Received: by qwj9 with SMTP id 9so1603404qwj.13
	for <multiple recipients>; Sat, 18 Dec 2010 10:41:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:in-reply-to
	:references:date:message-id:subject:from:to:cc:content-type;
	bh=ycoJNRb3YNO7SDl7DrHgm0OOduOIoe7DdB+LuVdQycs=;
	b=SDxXqdsQxVUIKg/wJu0Alp68GLtNyNtfY6tR9JXjUjIEUf5fhIiMFDQt0997jwwdD+
	k76Vr6c80rxv97C7HetMGbFkQuk3oq7RZcfo6zWM17rzc5ACuehluvc09yFKp0aq6oNH
	RCAxcoKF8FYPpiMSfDzANqutSL8/wuKRWxjvw=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=rVeR2DON1iDEG9Hc1ka9rOrn+JgAQfa9s7XfJItFv1RK559XSaJQfyCvC6TiiG2Mwz
	GloSAXzrscjfIwooAdSW0xdH4YSOZWDJqgXHkVmNWQD8Qnjk/nfEcT0s0JGwnK5svpad
	1BG4dUC8eSB1RV67fN8xsXQk/0nnyqRVJ9cpQ=
MIME-Version: 1.0
Received: by 10.229.189.72 with SMTP id dd8mr2170673qcb.18.1292697673575; Sat,
	18 Dec 2010 10:41:13 -0800 (PST)
Received: by 10.220.175.141 with HTTP; Sat, 18 Dec 2010 10:41:13 -0800 (PST)
In-Reply-To: <201012181421.oBIELTSd093635@svn.freebsd.org>
References: <201012181421.oBIELTSd093635@svn.freebsd.org>
Date: Sat, 18 Dec 2010 18:41:13 +0000
Message-ID: <AANLkTim-9o3XmdeQF1+OfR8ToDzHqWyDJOR7sgziz5t5@mail.gmail.com>
From: Paul B Mahol <onemda@gmail.com>
To: Tijl Coosemans <tijl@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r216518 - in head/sys/dev: if_ndis le malo sound/pci
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2010 18:41:15 -0000

On 12/18/10, Tijl Coosemans <tijl@freebsd.org> wrote:
> Author: tijl
> Date: Sat Dec 18 14:21:28 2010
> New Revision: 216518
> URL: http://svn.freebsd.org/changeset/base/216518
>
> Log:
>   Use convenience functions where possible instead of accessing the PCI
>   configuration registers directly.
>
>   Remove pci_enable_io calls where they are redundant. The PCI bus driver
>   will set the right bits when the corresponding bus resource is activated.
>
>   Remove redundant pci_* function calls from suspend/resume methods. The
>   bus driver already saves and restores the PCI configuration.
>
>   Reviewed by:	jhb
>   Approved by:	kib (mentor)

Please revert change to if_ndis regarding introduction of pci_get_subvendor().

You compare 16bit value with 32bit value - this will always fail.