From owner-cvs-src@FreeBSD.ORG Thu May 15 13:04:47 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 739CF37B404 for ; Thu, 15 May 2003 13:04:47 -0700 (PDT) Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE49443F93 for ; Thu, 15 May 2003 13:04:45 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 6542 invoked from network); 15 May 2003 20:04:43 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 15 May 2003 20:04:43 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h4FK4fp0035422; Thu, 15 May 2003 16:04:41 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030515131220.P7106@gamplex.bde.org> Date: Thu, 15 May 2003 16:04:50 -0400 (EDT) From: John Baldwin To: Bruce Evans cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Kimura Fuyuki cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha machdep.c src/sys/alpha/osf1 osf1_signal.c src/sys/amd64/amd64 machdep.c src/sys/compat/linprocfs linprocfs.c src/sys/compat/svr4 svr4_filio.c svr4_misc.c src/sys/i X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2003 20:04:47 -0000 On 15-May-2003 Bruce Evans wrote: > On Wed, 14 May 2003, John Baldwin wrote: > >> On 14-May-2003 Kimura Fuyuki wrote: >> > At Tue, 13 May 2003 13:36:02 -0700 (PDT), >> > John Baldwin wrote: >> >> 1.61 +23 -4 src/sys/sys/signalvar.h >> > >> > There seems to be missing #include . >> >> Yes. :( I wonder if it shouldn't be in sys/_lock.h >> instead. > > Less than it should include for its use of u_int (i.e., > it shouldn't). Hmm, I can fix it to use unsigned instead if that is preferred: Index: _lock.h =================================================================== RCS file: /usr/cvs/src/sys/sys/_lock.h,v retrieving revision 1.8 diff -u -r1.8 _lock.h --- _lock.h 7 Jun 2002 14:37:09 -0000 1.8 +++ _lock.h 15 May 2003 14:45:51 -0000 @@ -35,7 +35,7 @@ struct lock_class *lo_class; const char *lo_name; /* Individual lock name. */ const char *lo_type; /* General lock type. */ - u_int lo_flags; + unsigned lo_flags; TAILQ_ENTRY(lock_object) lo_list; /* List of all locks in system. */ struct witness *lo_witness; }; Index: _mutex.h =================================================================== RCS file: /usr/cvs/src/sys/sys/_mutex.h,v retrieving revision 1.9 diff -u -r1.9 _mutex.h --- _mutex.h 29 Dec 2002 11:14:41 -0000 1.9 +++ _mutex.h 15 May 2003 14:46:07 -0000 @@ -37,7 +37,7 @@ struct mtx { struct lock_object mtx_object; /* Common lock properties. */ volatile uintptr_t mtx_lock; /* Owner and flags. */ - volatile u_int mtx_recurse; /* Number of recursive holds. */ + volatile unsigned mtx_recurse; /* Number of recursive holds. */ TAILQ_HEAD(, thread) mtx_blocked; /* Threads blocked on us. */ LIST_ENTRY(mtx) mtx_contested; /* Next contested mtx. */ -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/