From owner-freebsd-ports-bugs@freebsd.org  Tue Aug 29 17:33:37 2017
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9352DDE13C2
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Tue, 29 Aug 2017 17:33:37 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 818D36B12F
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 29 Aug 2017 17:33:37 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7THXbQ9096200
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 29 Aug 2017 17:33:37 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 219780] [fix proposal] USE_PACKAGE_DEPENDS broken if PACKAGES'
 definition contains colons
Date: Tue, 29 Aug 2017 17:33:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Ports Framework
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: bugzilla.freebsd@omnilan.de
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: portmgr@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-219780-13-h0VdjT3Kl2@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-219780-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-219780-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Aug 2017 17:33:37 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219780

--- Comment #2 from Harald Schmalzbauer <bugzilla.freebsd@omnilan.de> ---
While the former does fix USE_PACKAGE_DEPENDS, the real problem with
https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?view=3Dlog&pathrev=3D4=
41712
persists and breaks several scripts here.

So please don't consider the proposal in the former comment as a possible f=
ix!

Since I'm not planning to rewrite my scripts and in my opinion, it's simply
wrong to define PKGFILE etc, with elsewhere unadequate escape characters, I
propose this patch:

Index: bsd.port.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- bsd.port.mk (Revision 448848)
+++ bsd.port.mk (Arbeitskopie)
@@ -2518,7 +2518,6 @@
 PKGREPOSITORYSUBDIR?=3D  All
 PKGREPOSITORY?=3D                ${PACKAGES}/${PKGREPOSITORYSUBDIR}
 .if exists(${PACKAGES})
-PACKAGES:=3D     ${PACKAGES:S/:/\:/g}
 _HAVE_PACKAGES=3D        yes
 PKGFILE?=3D              ${PKGREPOSITORY}/${PKGNAME}${PKG_SUFX}
 .else
@@ -3302,19 +3301,19 @@
 # Package

 .if defined(_HAVE_PACKAGES)
-_EXTRA_PACKAGE_TARGET_DEP+=3D ${PKGFILE}
-_PORTS_DIRECTORIES+=3D   ${PKGREPOSITORY}
+_EXTRA_PACKAGE_TARGET_DEP+=3D ${PKGFILE:S/:/\:/g}
+_PORTS_DIRECTORIES+=3D   ${PKGREPOSITORY:S/:/\:/g}

-${PKGFILE}: ${WRKDIR_PKGFILE} ${PKGREPOSITORY}
+${PKGFILE:S/:/\:/g}: ${WRKDIR_PKGFILE:S/:/\:/g} ${PKGREPOSITORY:S/:/\:/g}
        @${LN} -f ${WRKDIR_PKGFILE} ${PKGFILE} 2>/dev/null \
                        || ${CP} -f ${WRKDIR_PKGFILE} ${PKGFILE}

 .  if ${PKGORIGIN} =3D=3D "ports-mgmt/pkg" || ${PKGORIGIN} =3D=3D
"ports-mgmt/pkg-devel"
-_EXTRA_PACKAGE_TARGET_DEP+=3D    ${PKGLATESTREPOSITORY}
-_PORTS_DIRECTORIES+=3D   ${PKGLATESTREPOSITORY}
-_EXTRA_PACKAGE_TARGET_DEP+=3D    ${PKGLATESTFILE}
+_EXTRA_PACKAGE_TARGET_DEP+=3D    ${PKGLATESTREPOSITORY:S/:/\:/g}
+_PORTS_DIRECTORIES+=3D   "${PKGLATESTREPOSITORY:S/:/\:/g}"
+_EXTRA_PACKAGE_TARGET_DEP+=3D    ${PKGLATESTFILE:S/:/\:/g}

-${PKGLATESTFILE}: ${PKGFILE} ${PKGLATESTREPOSITORY}
+${PKGLATESTFILE:S/:/\:/g}: ${PKGFILE:S/:/\:/g} ${PKGLATESTREPOSITORY:S/:/\=
:/g}
        ${INSTALL} -l rs ${PKGFILE} ${PKGLATESTFILE}
 .  endif

-harry

--=20
You are receiving this mail because:
You are on the CC list for the bug.=