From owner-freebsd-ports@FreeBSD.ORG Mon Jun 6 01:25:17 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2B5D106566B for ; Mon, 6 Jun 2011 01:25:17 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id A3F778FC0C for ; Mon, 6 Jun 2011 01:25:17 +0000 (UTC) Received: by iwn33 with SMTP id 33so4242902iwn.13 for ; Sun, 05 Jun 2011 18:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=p3l/cqGi6HA3/UmUS7eOmyKvj9bGai3gOsDfmpJ1DbY=; b=DH0kf4CsMvlvYsT3PqxgDSP6lUabkeWTacAIvIob974Et80PTNsdKryw0Qb2Hp/GaV W9Wx8VJgQwg7qteJFCqYa3ipeaFjK7fUN4wapqXhR5X6hgBiEfs+0KkiJf8vuHYAB5m4 lxvomqapc6XjkNipw7lJL4ySHH8WeB4zimcIY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-type:content-disposition:in-reply-to :x-openpgp-key-id:x-openpgp-key-fingerprint:x-openpgp-key-url; b=KebK8uh2OV2uk+uEspagr3Gx1K2atcFbUK6hFSFmeGp69WfBo6OUK6SNIklCORhPzo Lg11uekCwFGtSWdb//YFieoJwF3ZfOF8SjtAj880pBieP6BtmNX6pYxX0IKGDibAaSAy s5T/F8SRV7ivzimlETQ2qXDoTo8+Fipnog2Ps= Received: by 10.43.60.205 with SMTP id wt13mr6460761icb.253.1307323517024; Sun, 05 Jun 2011 18:25:17 -0700 (PDT) Received: from DataIX.net (adsl-99-19-42-166.dsl.klmzmi.sbcglobal.net [99.19.42.166]) by mx.google.com with ESMTPS id d8sm2393876icy.21.2011.06.05.18.25.14 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Jun 2011 18:25:15 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p561PBdI074432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 5 Jun 2011 21:25:12 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p561P9ZP074431; Sun, 5 Jun 2011 21:25:09 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Sun, 5 Jun 2011 21:25:09 -0400 From: Jason Hellenthal To: Scot Hetzel Message-ID: <20110606012509.GA14126@DataIX.net> References: <20110603161358.GB1247@procyon.xvoid.org> <19946.7125.169246.84228@jerusalem.litteratus.org> <60F86515-B592-4B98-BE53-904206B6B183@lists.zabbadoz.net> <19946.11846.502201.644665@jerusalem.litteratus.org> <20110605012320.GA46823@DataIX.net> <20110605022434.GB46823@DataIX.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline In-Reply-To: X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: jharris@widomaker.com, Robert Huff , freebsd-ports@freebsd.org Subject: Re: Fping with WITH_IPV6=YES X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: jhell@DataIX.net List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2011 01:25:18 -0000 --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Scot, On Sun, Jun 05, 2011 at 09:25:46AM -0500, Scot Hetzel wrote: > On Sat, Jun 4, 2011 at 9:24 PM, Jason Hellenthal wrote: > > > > And if I might suggest, remove the old ifdef and replace with ... > > > > pre-extract: > > .if defined(WITH_IPV6) > > .undef WITH_IPV6 > > =A0@${ECHO_MSG} "******************************************************= ***************" > > =A0@${ECHO_MSG} "*** IPV6 IS NOT ENABLED FOR net/fping, IT DOES NOT WOR= K WITH IPV4 ***" > > =A0@${ECHO_MSG} "*** =A0 =A0 =A0 =A0 =A0 =A0 PLEASE SEE/USE net/fping+i= pv6 INSTEAD =A0 =A0 =A0 =A0 =A0 =A0 ***" > > =A0@${ECHO_MSG} "*** =A0 =A0THESE PORTS CAN CO-EXIST TOGETHER AND BOTH = BE INSTALLED =A0 =A0***" > > =A0@${ECHO_MSG} "******************************************************= ***************" > > =A0@sleep 10 > > .endif > > >=20 > I would suggest the following changes for net/fping: >=20 > - remove the ipv6 category from net/fping, since it is ipv4 only. >=20 > Change comment to: > COMMENT=3D Quickly ping N hosts w/o flooding the network - IPv4 Only vers= ion >=20 > - Remove this define from the ports Makefile: >=20 > .if defined(WITH_IPV6) > # IPv6 not enabled by default, as it does not work together with IPv4. > CFLAGS+=3D -DIPV6 > .endif >=20 > I also noticed that the net/fping includes a source address patch > (net/fping/files/patch-sourceaddr) that is missing in the > net/fping+ipv6 port. The patch seems to support both ipv4 or ipv6 > depending on if IPV6 is defined. >=20 Agreed. Either will do as it still has the same effect.=20 Thinking about this while at work and looking over the source for fping, it would be really nice if we snatched it up, modified it so ipv4+ipv6 worked together and then just slammed it into /usr/src/sbin/fping. The license is really permisable MIT like license and the code size is rather small. I think Solaris already has or has had a utility very similiar to the functionality of this and would make sense to to have it in our tree as well. Language files blank comments code ----------------------------------------------------- C 1 633 305 1804 ----------------------------------------------------- --=20 "Unity can only be manifested by the Binary. Unity itself and the idea of U= nity are already two." -- Buddha Regards, (jhell) Jason Hellenthal --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJN7Cx0AAoJEJBXh4mJ2FR+4ZkH/2zjhVMQzdiZtaykNwV3iOpN yGyAkU8GGF3ImCLW/9gpm0ejLC3WRepFLu5a8hAgAlX5JY6lGMyHlxyUXqB30Y6U dlMpwUfhB64jMhct8OofqGkbGja7pis3WguU/4VNvehYuiSn2DAho+Hpm5JuxpB1 nvuYS1PMvOuKKNI+Ejm+OOHkktnDOrtF8/RYGudGGZ27FZuKSdj1JvoV7QqRk5BY 084oJxdqD7j6bsK6oB/zHNfxJUL4SyThDC2vbCY8+SJDX5YwovjRtLUDNUmcGC+8 J8FcDIsSfn4nyfoJDUAKi1y6AX4QUst05Pm/DZAnQeX9W4zGMO/doNbGr9Qq4N4= =SR0y -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE--