From owner-cvs-all Mon Jul 1 15: 9:56 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 336E237B400; Mon, 1 Jul 2002 15:09:50 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4119343E09; Mon, 1 Jul 2002 15:09:49 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id g61M9lri022865; Mon, 1 Jul 2002 15:09:47 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id g61M9lJk022864; Mon, 1 Jul 2002 15:09:47 -0700 Date: Mon, 1 Jul 2002 15:09:47 -0700 From: Brooks Davis To: Dima Dorfman Cc: sheldonh@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: doc/en_US.ISO8859-1/share/sgml authors.ent doc/en_US.ISO8859-1/articles/contributors article.sgml Message-ID: <20020701150947.D25785@Odin.AC.HMC.Edu> References: <20020701154046.GN85531@starjuice.net> <20020701214430.880793E1E@turbine.trit.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="llIrKcgUOe3dCx0c" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020701214430.880793E1E@turbine.trit.org>; from dima@trit.org on Mon, Jul 01, 2002 at 09:44:30PM +0000 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --llIrKcgUOe3dCx0c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 01, 2002 at 09:44:30PM +0000, Dima Dorfman wrote: > Isn't this backwards? "Reviewed by" implies "Approved by", but not > the other way around; a maintainer (or mentor) might "Approve" a patch > without necessarily looking at ("Reviewing") it, but someone that > "Reviewed" a patch always "Approves" it. The text you proposed for > the Committers' Guide has the same problem. I'm pretty sure you're confused. "Reviewed by" just means you read the patch and don't object to it. "Approved by" means you grant permission to commit it based on your authority to do so (as a mentor, a maintainer, a hat, etc). In general approval implies review, though certain exceptions such as some doc commits during code freeze exist. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --llIrKcgUOe3dCx0c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9INMqXY6L6fI4GtQRAsHHAJ4nkTH8EkIUXCldQ4k8uC1OsdhMwACg34c7 nY7OKW21kWnurNL3NVGQPhM= =2nXN -----END PGP SIGNATURE----- --llIrKcgUOe3dCx0c-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message